Sign upLogin

notifme/notifme-sdk

View on GitHub
Star

Showing 333 of 333 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    const { subscription, title, ...rest } =
      request.customize ? (await request.customize(this.id, request)) : request
Severity: Minor
Found in src/providers/webpush/notificationCatcher.js and 1 other location - About 35 mins to fix
src/providers/push/notificationCatcher.js on lines 8..9

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    const { registrationToken, title, ...rest } =
      request.customize ? (await request.customize(this.id, request)) : request
Severity: Minor
Found in src/providers/push/notificationCatcher.js and 1 other location - About 35 mins to fix
src/providers/webpush/notificationCatcher.js on lines 8..9

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

              return response.json();
Severity: Major
Found in lib/providers/sms/plivo.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                  return response.text();
    Severity: Major
    Found in lib/providers/sms/plivo.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                    return _context.abrupt("return", responseText.match(/<MessageId>(.*)<\/MessageId>/)[1]);
      Severity: Major
      Found in lib/providers/email/ses.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                      return response.text();
        Severity: Major
        Found in lib/providers/sms/seven.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                        return response.text();
          Severity: Major
          Found in lib/providers/sms/46elks.js - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                          if (bcc && bcc.length > 0) bcc.forEach(function (email) {
                return form.append('bcc', email);
              });
            Severity: Minor
            Found in lib/providers/email/mailgun.js and 1 other location - About 30 mins to fix
            lib/providers/email/mailgun.js on lines 68..70

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                          if (cc && cc.length > 0) cc.forEach(function (email) {
                return form.append('cc', email);
              });
            Severity: Minor
            Found in lib/providers/email/mailgun.js and 1 other location - About 30 mins to fix
            lib/providers/email/mailgun.js on lines 71..73

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                      ...(bcc && bcc.length > 0 ? { bcc: bcc.map((email) => ({ email })) } : null)
            Severity: Minor
            Found in src/providers/email/sendgrid.js and 1 other location - About 30 mins to fix
            src/providers/email/sendgrid.js on lines 29..29

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                      ...(cc && cc.length > 0 ? { cc: cc.map((email) => ({ email })) } : null),
            Severity: Minor
            Found in src/providers/email/sendgrid.js and 1 other location - About 30 mins to fix
            src/providers/email/sendgrid.js on lines 30..30

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function send has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              async send (request: EmailRequestType): Promise<string> {
    if (
      request.text &&
      typeof request.text !== 'string' &&
      !(request.text instanceof Buffer) &&
            Severity: Minor
            Found in src/providers/email/ses.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function send has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              async send (request: SmsRequestType): Promise<string> {
    const { from, to, text, type, ttl, messageClass } =
      request.customize ? (await request.customize(this.id, request)) : request
    const response = await fetch('https://rest.nexmo.com/sms/json', {
      method: 'POST',
            Severity: Minor
            Found in src/providers/sms/nexmo.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language