Sign upLogin

obartra/ssim

View on GitHub
Star

Showing 32 of 32 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export function sum(xn: number[]): number {
  let out = 0

  for (let x = 0; x < xn.length; x++) {
    out += xn[x]
Severity: Minor
Found in src/math.ts and 1 other location - About 50 mins to fix
src/math.ts on lines 78..86

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export function sum2d({ data }: Matrix): number {
  let out = 0

  for (let x = 0; x < data.length; x++) {
    out += data[x]
Severity: Minor
Found in src/math.ts and 1 other location - About 50 mins to fix
src/math.ts on lines 37..44

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function genUQI has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

  μ12: Matrix,
  σ12: Matrix,
  μ1Sq: Matrix,
  μ2Sq: Matrix,
  σ1Sq: Matrix,
Severity: Minor
Found in src/ssim.ts - About 45 mins to fix

    Function reshape has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      c: Matrix,
  shape: Shape,
  ma: number,
  mb: number,
  na: number,
    Severity: Minor
    Found in src/matlab/conv2.ts - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                for (let j = 0; j < refWidth; j++) {
            data[(i + r1) * cWidth + j + c1] += ref[i * refWidth + j] * br1c1
          }
      Severity: Major
      Found in src/matlab/conv2.ts - About 45 mins to fix

        Function sub has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          { data: ref, width: refWidth }: Matrix,
  x: number,
  height: number,
  y: number,
  width: number
        Severity: Minor
        Found in src/matlab/sub.ts - About 35 mins to fix

          Function windowCovariance has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            pixels1: ImageMatrix,
  pixels2: ImageMatrix,
  sums1: any,
  sums2: any,
  windowSize: number
          Severity: Minor
          Found in src/weberSsim.ts - About 35 mins to fix

            Function validateOptions has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            function validateOptions(options: Options) {
  Object.keys(options).forEach((option) => {
    if (!(option in defaults)) {
      throw new Error(`"${option}" is not a valid option`)
    }
            Severity: Minor
            Found in src/index.ts - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function windowMatrix has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            export function windowMatrix(
  sumMatrix: any,
  windowSize: number,
  divisor: number
) {
            Severity: Minor
            Found in src/weberSsim.ts - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function padMatrix has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            function padMatrix(
  A: Matrix,
  frows: number,
  fcols: number,
  pad: PaddingValue
            Severity: Minor
            Found in src/matlab/imfilter.ts - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                array[grayIndex] = (77 * d[i] + 150 * d[i + 1] + 29 * d[i + 2] + 128) >> 8
            Severity: Minor
            Found in src/matlab/rgb2gray.ts and 1 other location - About 30 mins to fix
            src/matlab/rgb2gray.ts on lines 39..39

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  0.29894 * d[i] + 0.58704 * d[i + 1] + 0.11402 * d[i + 2] + 0.5
            Severity: Minor
            Found in src/matlab/rgb2gray.ts and 1 other location - About 30 mins to fix
            src/matlab/rgb2gray.ts on lines 56..56

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language