Showing 402 of 402 total issues
Variable "parent_id" is not in valid camel caps format Open
if (!empty($obCategoryItem->parent_id)) {- Exclude checks
Exception type missing for @throws tag in function comment Open
* @throws- Exclude checks
Variable "old_price_value" is not in valid camel caps format Open
$fOldPrice = $this->old_price_value;- Exclude checks
Expected 1 space after FUNCTION keyword; 0 found Open
$arElementIDList = (array) Product::whereHas('site', function($obQuery) {- Exclude checks
Variable "category_id" is not in valid camel caps format Open
$this->addCategoryData($obProductItem->category_id);- Exclude checks
Variable "updated_at" is not in valid camel caps format Open
'mtime' => $obCategoryItem->updated_at,- Exclude checks
Doc comment for parameter "$obProgressBar" missing Open
/**- Exclude checks
Doc comment for parameter "$iSiteID" missing Open
/**- Exclude checks
Variable "price_value" is not in valid camel caps format Open
$fPrice = $this->price_value;- Exclude checks
Variable "category_id" is not in valid camel caps format Open
$this->addCategoryData($obTagItem->category_id);- Exclude checks
Declare public methods first,then protected ones and finally private ones Open
public function handle()- Exclude checks
Variable "tax_percent" is not in valid camel caps format Open
$fPrice = TaxHelper::instance()->getPriceWithTax($this->discount_price_value, $this->tax_percent);- Exclude checks
Doc comment for parameter "$arAddParamList" missing Open
/**- Exclude checks
Missing blank line before return statement Open
return;- Exclude checks
Variable "price_list" is not in valid camel caps format Open
$fPrice = array_get($this->price_list, $iActivePriceType.'.price');- Exclude checks
Doc comment for parameter "$obProgressBar" missing Open
/**- Exclude checks
Expected 1 space after FUNCTION keyword; 0 found Open
->sort(function($obPrevItem, $obNextItem) {- Exclude checks
Variable "product_id_list" is not in valid camel caps format Open
$arProductIDList = (array) $this->product_id_list;- Exclude checks
Similar blocks of code found in 8 locations. Consider refactoring. Open
<?php namespace Lovata\Shopaholic\Classes\Store\Tax;
use Lovata\Toolbox\Classes\Store\AbstractStoreWithoutParam;
use Lovata\Shopaholic\Models\Tax;- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 46.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 8 locations. Consider refactoring. Open
<?php namespace Lovata\Shopaholic\Classes\Store\PromoBlock;
use Lovata\Toolbox\Classes\Store\AbstractStoreWithoutParam;
use Lovata\Shopaholic\Models\PromoBlock;- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 46.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76