Sign upLogin

offirgolan/ember-light-table

View on GitHub
Star

Showing 10 of 10 total issues

Table has 22 functions (exceeds 20 allowed). Consider refactoring.
Open

@classic
export default class Table extends EmberObject.extend({
  /**
   * @property columns
   * @type {Ember.Array}
Severity: Minor
Found in addon/classes/Table.js - About 2 hrs to fix

    Function onRowClick has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        onRowClick(row, e) {
      let rows = this.table.rows;
      let multiSelect = this.multiSelect;
      let multiSelectRequiresKeyboard = this.multiSelectRequiresKeyboard;
      let canSelect = this.canSelect;
    Severity: Minor
    Found in addon/components/lt-body.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function onRowClick has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        onRowClick(row, e) {
      let rows = this.table.rows;
      let multiSelect = this.multiSelect;
      let multiSelectRequiresKeyboard = this.multiSelectRequiresKeyboard;
      let canSelect = this.canSelect;
    Severity: Minor
    Found in addon/components/lt-body.js - About 1 hr to fix

      Function _mouseMove has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        _mouseMove(e) {
    if (this.isResizing) {
      e.preventDefault();
      e.stopPropagation();
      Severity: Minor
      Found in addon/components/lt-column-resizer.js - About 1 hr to fix

        Function onMediaChange has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          onMediaChange: observer('table.allColumns.[]', function () {
    let responsive = this.responsive;
    let matches = this.media.matches;
    let breakpoints = this.breakpoints;
    let table = this.table;
        Severity: Minor
        Found in addon/components/light-table.js - About 1 hr to fix

          Function setupScrollOffset has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            setupScrollOffset: action(function (element) {
    let { scrollTo, _scrollTo, scrollToRow, _scrollToRow } = this;
    let targetScrollOffset = null;

    this.setProperties({ _scrollTo: scrollTo, _scrollToRow: scrollToRow });
          Severity: Minor
          Found in addon/components/lt-body.js - About 1 hr to fix

            Function setupScrollOffset has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

              setupScrollOffset: action(function (element) {
    let { scrollTo, _scrollTo, scrollToRow, _scrollToRow } = this;
    let targetScrollOffset = null;

    this.setProperties({ _scrollTo: scrollTo, _scrollToRow: scrollToRow });
            Severity: Minor
            Found in addon/components/lt-body.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function onColumnClick has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                onColumnClick(column) {
      if (column.sortable && this.sortOnClick) {
        if (column.sorted) {
          column.toggleProperty('ascending');
        } else {
            Severity: Minor
            Found in addon/mixins/table-header.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function _mouseMove has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              _mouseMove(e) {
    if (this.isResizing) {
      e.preventDefault();
      e.stopPropagation();
            Severity: Minor
            Found in addon/components/lt-column-resizer.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function totalWidth has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              totalWidth: computed('visibleColumns.@each.width', function () {
    let visibleColumns = this.visibleColumns;
    let widths = visibleColumns.getEach('width');
    let unit = (widths[0] || '').match(/\D+$/);
    let totalWidth = 0;
            Severity: Minor
            Found in addon/components/light-table.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language