Sign upLogin

oglimmer/citybuilder

View on GitHub
Star

Showing 157 of 157 total issues

Avoid deeply nested control flow statements.
Open

                    for(var k = start ; k <= end ; k++) {
                        if(k!==start) {
                            tempTxtDisp += " / ";
                        }
                        tempTxtDisp += UIServices.getHouseTypeText(k);
Severity: Major
Found in client/game/Card.js - About 45 mins to fix

    Function getButton has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    CanvasManager.prototype.getButton = function(x,y) {
    if(this.enabled) {
        for(var i = this.elements.length - 1 ; i>= 0 ; i--) {
            var ele = this.elements[i][2];
            if(typeof(ele.atPos) === 'function' && ele.atPos(x,y)) {
    Severity: Minor
    Found in client/game/CanvasManager.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                        if(this.cardsToAuction[j].cardsToSelect[i].id == cardId) {
                        c = this.cardsToAuction[j].cardsToSelect[i];
                    }
    Severity: Major
    Found in server/rule_game.js - About 45 mins to fix

      Function calcSupplies has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      RentalCard.prototype.calcSupplies = function(field, fields) {    
    Card.forEachField(this.range, field, fields, function(surroundingElement) {
        if(surroundingElement.type == FieldType.HOUSE) {
            if(typeof surroundingElement.attachedCard.supply[RentalCard.getTypeFromField(field)] === 'undefined') {
                surroundingElement.attachedCard.supply[RentalCard.getTypeFromField(field)] = 0;
      Severity: Minor
      Found in server/cards/card_basecards.js - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                                      psoc.emit('sendPlayerData', {gameId:savedGame._id, playerId: aPlayer._id, playerNo: aPlayer.no, availableActions: aPlayer.availableActions });
      Severity: Minor
      Found in server/ioHandler.js and 1 other location - About 40 mins to fix
      server/ioHandler.js on lines 53..53

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                                  psoc.emit('sendPlayerData', {gameId:game._id, playerId: savedPlayer._id, playerNo: savedPlayer.no, availableActions: savedPlayer.availableActions }); // sendPlayerData
      Severity: Minor
      Found in server/ioHandler.js and 1 other location - About 40 mins to fix
      server/ioHandler.js on lines 98..98

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function createField has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      GameField.prototype.createField = function(x,y,houseType,maxPop,localLevel) {
      Severity: Minor
      Found in server/rule_gamefield.js - About 35 mins to fix

        Function BuildElectronicCard has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function BuildElectronicCard(id,no,range,profitConfig,localLevelMod) {
        Severity: Minor
        Found in server/cards/card_electroniccards.js - About 35 mins to fix

          Function BuildJeweleryCard has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          function BuildJeweleryCard(id,no,range,profitConfig,localLevelMod) {
          Severity: Minor
          Found in server/cards/card_jewelerycards.js - About 35 mins to fix

            Function Button has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            function Button(label,x, y, width, onclick) {
            Severity: Minor
            Found in client/game/Button.js - About 35 mins to fix

              Function BuildClothingCard has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              function BuildClothingCard(id,no,range,profitConfig,localLevelMod) {
              Severity: Minor
              Found in server/cards/card_clothingcards.js - About 35 mins to fix

                Function Field has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                function Field(x,y,type,houseCard,localLevel) {
                Severity: Minor
                Found in server/rule_field.js - About 35 mins to fix

                  Function add has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  GameField.prototype.add = function(width, height, houseType, maxPop, localLevel) {
                  Severity: Minor
                  Found in server/rule_gamefield.js - About 35 mins to fix

                    Function BuildCriminalCard has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    function BuildCriminalCard(id,no,range,profitConfig,localLevelMod) {
                    Severity: Minor
                    Found in server/cards/card_criminalcards.js - About 35 mins to fix

                      Function BuildGroceriesCard has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      function BuildGroceriesCard(id,no,range,profitConfig,localLevelMod) {
                      Severity: Minor
                      Found in server/cards/card_groceriescards.js - About 35 mins to fix

                        Function BuildLocalLevelCard has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                        function BuildLocalLevelCard(id,no,range,profitConfig,localLevelMod) {
                        Severity: Minor
                        Found in server/cards/card_locallevelcards.js - About 35 mins to fix

                          Function BuildRestaurantCard has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                          function BuildRestaurantCard(id,no,range,profitConfig,localLevelMod) {
                          Severity: Minor
                          Found in server/cards/card_restaurantcards.js - About 35 mins to fix

                            Function newPeople has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                            Open

                            NewPeopleCard.newPeople = function(field,changedFields) {
    if(field.type == FieldType.HOUSE) {
        var oldHouseType = field.attachedCard.houseType;        
        var currentHouseTypeName = HouseTypeReverse[oldHouseType];
        var currentLocalLevel = null;
                            Severity: Minor
                            Found in server/cards/card_other.js - About 35 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function onclick has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                            Open

                            CanvasManager.prototype.onclick = function(x, y) {
    if(this.enabled) {
        for(var i = this.elements.length - 1 ; i>= 0 ; i--) {
            var ele = this.elements[i][2];
            if(typeof(ele.onclick) === 'function' && ele.onclick(x,y)) {
                            Severity: Minor
                            Found in client/game/CanvasManager.js - About 35 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function GameField has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                            Open

                            function GameField(game) {
    this.fields = {};
    this.minX = 0;
    this.minY = 0;
    this.maxX = 8;
                            Severity: Minor
                            Found in server/rule_gamefield.js - About 35 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Severity
                            Category
                            Status
                            Source
                            Language