Sign upLogin

omissis/go-jsonschema

View on GitHub
Star

Showing 36 of 36 total issues

File schema_generator.go has 728 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package generator

import (
    "errors"
    "fmt"
Severity: Minor
Found in pkg/generator/schema_generator.go - About 7 hrs to fix

    Method schemaGenerator.generateStructType has a Cognitive Complexity of 49 (exceeds 20 allowed). Consider refactoring.
    Open

    func (g *schemaGenerator) generateStructType(
    t *schemas.Type,
    scope nameScope,
) (codegen.Type, error) {
    if len(t.Properties) == 0 {
    Severity: Minor
    Found in pkg/generator/schema_generator.go - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method schemaGenerator.generateEnumType has a Cognitive Complexity of 46 (exceeds 20 allowed). Consider refactoring.
    Open

    func (g *schemaGenerator) generateEnumType(
    t *schemas.Type, scope nameScope,
) (codegen.Type, error) {
    if len(t.Enum) == 0 {
        return nil, errEnumArrCannotBeEmpty
    Severity: Minor
    Found in pkg/generator/schema_generator.go - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method schemaGenerator.generateTypeInline has a Cognitive Complexity of 46 (exceeds 20 allowed). Consider refactoring.
    Open

    func (g *schemaGenerator) generateTypeInline(
    t *schemas.Type,
    scope nameScope,
) (codegen.Type, error) {
    two := 2
    Severity: Minor
    Found in pkg/generator/schema_generator.go - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method schemaGenerator.generateStructType has 139 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (g *schemaGenerator) generateStructType(
    t *schemas.Type,
    scope nameScope,
) (codegen.Type, error) {
    if len(t.Properties) == 0 {
    Severity: Major
    Found in pkg/generator/schema_generator.go - About 4 hrs to fix

      Method schemaGenerator.generateEnumType has 115 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (g *schemaGenerator) generateEnumType(
    t *schemas.Type, scope nameScope,
) (codegen.Type, error) {
    if len(t.Enum) == 0 {
        return nil, errEnumArrCannotBeEmpty
      Severity: Major
      Found in pkg/generator/schema_generator.go - About 3 hrs to fix

        Method schemaGenerator.generateReferencedType has 108 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (g *schemaGenerator) generateReferencedType(ref string) (codegen.Type, error) {
    fileName := ref

    var scope, defName string
        Severity: Major
        Found in pkg/generator/schema_generator.go - About 3 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          package types

import (
    "errors"
    "fmt"
          Severity: Major
          Found in pkg/types/date.go and 1 other location - About 3 hrs to fix
          pkg/types/time.go on lines 1..40

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 269.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          package types

import (
    "errors"
    "fmt"
          Severity: Major
          Found in pkg/types/time.go and 1 other location - About 3 hrs to fix
          pkg/types/date.go on lines 1..40

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 269.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function PrimitiveTypeFromJSONSchemaType has 103 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func PrimitiveTypeFromJSONSchemaType(
    jsType,
    format string,
    pointer,
    minIntSize bool,
          Severity: Major
          Found in pkg/codegen/utils.go - About 3 hrs to fix

            Method schemaGenerator.generateReferencedType has a Cognitive Complexity of 36 (exceeds 20 allowed). Consider refactoring.
            Open

            func (g *schemaGenerator) generateReferencedType(ref string) (codegen.Type, error) {
    fileName := ref

    var scope, defName string
            Severity: Minor
            Found in pkg/generator/schema_generator.go - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method schemaGenerator.structFieldValidators has 70 lines of code (exceeds 50 allowed). Consider refactoring.
            Open

            func (g *schemaGenerator) structFieldValidators(
    validators []validator,
    f codegen.StructField,
    t codegen.Type,
    isNillable bool,
            Severity: Minor
            Found in pkg/generator/schema_generator.go - About 1 hr to fix

              Method schemaGenerator.generateType has 68 lines of code (exceeds 50 allowed). Consider refactoring.
              Open

              func (g *schemaGenerator) generateType(
    t *schemas.Type,
    scope nameScope,
) (codegen.Type, error) {
    typeIndex := 0
              Severity: Minor
              Found in pkg/generator/schema_generator.go - About 1 hr to fix

                Method schemaGenerator.generateTypeInline has 65 lines of code (exceeds 50 allowed). Consider refactoring.
                Open

                func (g *schemaGenerator) generateTypeInline(
    t *schemas.Type,
    scope nameScope,
) (codegen.Type, error) {
    two := 2
                Severity: Minor
                Found in pkg/generator/schema_generator.go - About 1 hr to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  func (yf *yamlFormatter) enumMarshal(declType codegen.TypeDecl) func(*codegen.Emitter) {
    return func(out *codegen.Emitter) {
        out.Commentf("Marshal%s implements %s.Marshal.", strings.ToUpper(formatYAML), formatYAML)
        out.Printlnf("func (j *%s) Marshal%s() (interface{}, error) {", declType.Name,
            strings.ToUpper(formatYAML))
                  Severity: Major
                  Found in pkg/generator/yaml_formatter.go and 1 other location - About 1 hr to fix
                  pkg/generator/json_formatter.go on lines 63..72

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 163.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  func (jf *jsonFormatter) enumMarshal(declType codegen.TypeDecl) func(*codegen.Emitter) {
    return func(out *codegen.Emitter) {
        out.Commentf("Marshal%s implements %s.Marshaler.", strings.ToUpper(formatJSON), formatJSON)
        out.Printlnf("func (j *%s) Marshal%s() ([]byte, error) {", declType.Name, strings.ToUpper(formatJSON))
        out.Indent(1)
                  Severity: Major
                  Found in pkg/generator/json_formatter.go and 1 other location - About 1 hr to fix
                  pkg/generator/yaml_formatter.go on lines 63..73

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 163.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method schemaGenerator.structFieldValidators has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
                  Open

                  func (g *schemaGenerator) structFieldValidators(
    validators []validator,
    f codegen.StructField,
    t codegen.Type,
    isNillable bool,
                  Severity: Minor
                  Found in pkg/generator/schema_generator.go - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method schemaGenerator.generateType has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
                  Open

                  func (g *schemaGenerator) generateType(
    t *schemas.Type,
    scope nameScope,
) (codegen.Type, error) {
    typeIndex := 0
                  Severity: Minor
                  Found in pkg/generator/schema_generator.go - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method schemaGenerator.generateReferencedType has 11 return statements (exceeds 4 allowed).
                  Open

                  func (g *schemaGenerator) generateReferencedType(ref string) (codegen.Type, error) {
    fileName := ref

    var scope, defName string
                  Severity: Major
                  Found in pkg/generator/schema_generator.go - About 1 hr to fix

                    Method schemaGenerator.generateType has 11 return statements (exceeds 4 allowed).
                    Open

                    func (g *schemaGenerator) generateType(
    t *schemas.Type,
    scope nameScope,
) (codegen.Type, error) {
    typeIndex := 0
                    Severity: Major
                    Found in pkg/generator/schema_generator.go - About 1 hr to fix
                      Severity
                      Category
                      Status
                      Source
                      Language