Sign upLogin

omissis/go-jsonschema

View on GitHub
Star

Showing 36 of 36 total issues

Method schemaGenerator.generateDeclaredType has 51 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (g *schemaGenerator) generateDeclaredType(
    t *schemas.Type, scope nameScope,
) (codegen.Type, error) {
    if decl, ok := g.output.declsBySchema[t]; ok {
        return &codegen.NamedType{Decl: decl}, nil
Severity: Minor
Found in pkg/generator/schema_generator.go - About 1 hr to fix

    Function PrimitiveTypeFromJSONSchemaType has 9 return statements (exceeds 4 allowed).
    Open

    func PrimitiveTypeFromJSONSchemaType(
    jsType,
    format string,
    pointer,
    minIntSize bool,
    Severity: Major
    Found in pkg/codegen/utils.go - About 55 mins to fix

      Method schemaGenerator.generateTypeInline has 9 return statements (exceeds 4 allowed).
      Open

      func (g *schemaGenerator) generateTypeInline(
    t *schemas.Type,
    scope nameScope,
) (codegen.Type, error) {
    two := 2
      Severity: Major
      Found in pkg/generator/schema_generator.go - About 55 mins to fix

        Function PrimitiveTypeFromJSONSchemaType has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            jsType,
    format string,
    pointer,
    minIntSize bool,
    minimum **float64,
        Severity: Minor
        Found in pkg/codegen/utils.go - About 45 mins to fix

          Method schemaGenerator.generateDeclaredType has 6 return statements (exceeds 4 allowed).
          Open

          func (g *schemaGenerator) generateDeclaredType(
    t *schemas.Type, scope nameScope,
) (codegen.Type, error) {
    if decl, ok := g.output.declsBySchema[t]; ok {
        return &codegen.NamedType{Decl: decl}, nil
          Severity: Major
          Found in pkg/generator/schema_generator.go - About 40 mins to fix

            Method HTTPLoader.Load has 6 return statements (exceeds 4 allowed).
            Open

            func (l *HTTPLoader) Load(uri, parentURI string) (*Schema, error) {
    u, err := url.Parse(uri)
    if err != nil {
        return nil, fmt.Errorf("failed to parse url: %w", err)
    }
            Severity: Major
            Found in pkg/schemas/loaders.go - About 40 mins to fix

              Method numericValidator.genBoundary has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  out *codegen.Emitter,
    checkPointer,
    pointerPrefix,
    value string,
    boundary *float64,
              Severity: Minor
              Found in pkg/generator/validator.go - About 35 mins to fix

                Function QualifiedFileName has 5 return statements (exceeds 4 allowed).
                Open

                func QualifiedFileName(fileName, parentFileName string, resolveExtensions []string) (string, error) {
    r, err := GetRefType(fileName)
    if err != nil {
        return "", err
    }
                Severity: Major
                Found in pkg/schemas/loaders.go - About 35 mins to fix

                  Method Package.Generate has 5 return statements (exceeds 4 allowed).
                  Open

                  func (p *Package) Generate(out *Emitter) {
    out.Comment(p.Comment)
    out.Printlnf("package %s", p.Name())

    if len(p.Imports) > 0 {
                  Severity: Major
                  Found in pkg/codegen/model.go - About 35 mins to fix

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                        if ext := t.GoJSONSchemaExtension; ext != nil {
        for _, pkg := range ext.Imports {
            g.output.file.Package.AddImport(pkg, "")
        }
                    Severity: Minor
                    Found in pkg/generator/schema_generator.go and 1 other location - About 35 mins to fix
                    pkg/generator/schema_generator.go on lines 690..698

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 105.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Method schemaGenerator.generateRootType has 5 return statements (exceeds 4 allowed).
                    Open

                    func (g *schemaGenerator) generateRootType() error {
    if g.schema.ObjectAsType == nil {
        return errSchemaHasNoRoot
    }
                    Severity: Major
                    Found in pkg/generator/schema_generator.go - About 35 mins to fix

                      Function NormalizeBounds has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
                      Open

                      func NormalizeBounds(
    minimum, maximum *float64, exclusiveMinimum, exclusiveMaximum *any,
) (*float64, *float64, bool, bool) {
    var minBound, maxBound *float64
                      Severity: Minor
                      Found in pkg/mathutils/utils.go - About 35 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                              if ext := t.GoJSONSchemaExtension; ext != nil {
            for _, pkg := range ext.Imports {
                g.output.file.Package.AddImport(pkg, "")
            }
                      Severity: Minor
                      Found in pkg/generator/schema_generator.go and 1 other location - About 35 mins to fix
                      pkg/generator/schema_generator.go on lines 384..392

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 105.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Method schemaGenerator.generateStructType has 5 return statements (exceeds 4 allowed).
                      Open

                      func (g *schemaGenerator) generateStructType(
    t *schemas.Type,
    scope nameScope,
) (codegen.Type, error) {
    if len(t.Properties) == 0 {
                      Severity: Major
                      Found in pkg/generator/schema_generator.go - About 35 mins to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            if exclusiveMinimum != nil {
        switch v := (*exclusiveMinimum).(type) {
        case bool:
            minExclusive = v
            minBound = minimum
                        Severity: Minor
                        Found in pkg/mathutils/utils.go and 1 other location - About 30 mins to fix
                        pkg/mathutils/utils.go on lines 36..54

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 102.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            if exclusiveMaximum != nil {
        switch v := (*exclusiveMaximum).(type) {
        case bool:
            maxExclusive = v
            maxBound = maximum
                        Severity: Minor
                        Found in pkg/mathutils/utils.go and 1 other location - About 30 mins to fix
                        pkg/mathutils/utils.go on lines 11..29

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 102.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Severity
                        Category
                        Status
                        Source
                        Language