Sign upLogin

onebeyond/onebeyond-studio-file-storage

View on GitHub
Star
src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs

Summary

Maintainability
D
2 days
Test Coverage

Method TestBlacklistStrategyFailsWhenContentTypeIsListedWithEntryInSignatureList has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    [TestMethod]
    public void TestBlacklistStrategyFailsWhenContentTypeIsListedWithEntryInSignatureList()
    {
        var options = new MimeTypeValidationOptions
        {
Severity: Minor
Found in src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs - About 1 hr to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        [TestMethod]
    public void TestBlacklistStrategyFailsWhenContentTypeIsListedWithEmptySignatureList()
    {
        var options = new MimeTypeValidationOptions
        {
    Severity: Major
    Found in src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs and 3 other locations - About 2 hrs to fix
    src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs on lines 64..95
    src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs on lines 97..128
    src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs on lines 130..161

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 196.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        [TestMethod]
    public void TestWhitelistStrategyFailsWhenContentTypeIsNotListed()
    {
        var options = new MimeTypeValidationOptions
        {
    Severity: Major
    Found in src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs and 3 other locations - About 2 hrs to fix
    src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs on lines 97..128
    src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs on lines 130..161
    src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs on lines 163..194

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 196.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        [TestMethod]
    public void TestBlacklistStrategySucceedsWhenContentTypeIsNotListed()
    {
        var options = new MimeTypeValidationOptions
        {
    Severity: Major
    Found in src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs and 3 other locations - About 2 hrs to fix
    src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs on lines 64..95
    src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs on lines 130..161
    src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs on lines 163..194

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 196.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        [TestMethod]
    public void TestWhitelistStrategySucceedsWhenContentTypeIsListedWithEmptySignatureList()
    {
        var options = new MimeTypeValidationOptions
        {
    Severity: Major
    Found in src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs and 3 other locations - About 2 hrs to fix
    src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs on lines 64..95
    src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs on lines 97..128
    src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs on lines 163..194

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 196.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        [TestMethod]
    public void TestWhitelistStrategySucceedsWhenContentTypeIsListedWithEmptyEntryInSignatureList()
    {
        var options = new MimeTypeValidationOptions
        {
    Severity: Major
    Found in src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs and 1 other location - About 2 hrs to fix
    src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs on lines 229..260

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 194.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        [TestMethod]
    public void TestBlacklistStrategyFailsWhenContentTypeIsListedWithEmptyEntryInSignatureList()
    {
        var options = new MimeTypeValidationOptions
        {
    Severity: Major
    Found in src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs and 1 other location - About 2 hrs to fix
    src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs on lines 196..227

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 194.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        [TestMethod]
    public void TestBlacklistStrategySucceedsWhenListIsEmpty()
    {
        var options = new MimeTypeValidationOptions
        {
    Severity: Major
    Found in src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs and 1 other location - About 2 hrs to fix
    src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs on lines 12..36

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 180.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        [TestMethod]
    public void TestWhitelistStrategyFailsWhenListIsEmpty()
    {
        var options = new MimeTypeValidationOptions
        {
    Severity: Major
    Found in src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs and 1 other location - About 2 hrs to fix
    src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs on lines 38..62

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 180.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status