Sign upLogin

openSUSE/open-build-service

View on GitHub
Star
src/api/app/components/notification_notifiable_link_component.rb

Summary

Maintainability
B
4 hrs
Test Coverage
F
54%

Method notifiable_link_text has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def notifiable_link_text
    case @notification.event_type
    when 'Event::RequestStatechange', 'Event::RequestCreate', 'Event::ReviewWanted'
      "#{helpers.request_type_of_action(@notification.notifiable)} Request ##{@notification.notifiable.number}"
    when 'Event::CommentForRequest'
Severity: Minor
Found in src/api/app/components/notification_notifiable_link_component.rb - About 2 hrs to fix

    Method notifiable_link_path has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def notifiable_link_path
    case @notification.event_type
    when 'Event::RequestStatechange', 'Event::RequestCreate', 'Event::ReviewWanted'
      Rails.application.routes.url_helpers.request_show_path(@notification.notifiable.number, notification_id: @notification.id)
    when 'Event::CommentForRequest'
    Severity: Minor
    Found in src/api/app/components/notification_notifiable_link_component.rb - About 1 hr to fix

      Method notifiable_link_path has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
      Wontfix

        def notifiable_link_path
    case @notification.event_type
    when 'Event::RequestStatechange', 'Event::RequestCreate', 'Event::ReviewWanted'
      Rails.application.routes.url_helpers.request_show_path(@notification.notifiable.number, notification_id: @notification.id)
    when 'Event::CommentForRequest'
      Severity: Minor
      Found in src/api/app/components/notification_notifiable_link_component.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method notifiable_link_text has a Cognitive Complexity of 10 (exceeds 8 allowed). Consider refactoring.
      Open

        def notifiable_link_text
    case @notification.event_type
    when 'Event::RequestStatechange', 'Event::RequestCreate', 'Event::ReviewWanted'
      "#{helpers.request_type_of_action(@notification.notifiable)} Request ##{@notification.notifiable.number}"
    when 'Event::CommentForRequest'
      Severity: Minor
      Found in src/api/app/components/notification_notifiable_link_component.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status