Sign upLogin

openSUSE/open-build-service

View on GitHub
Star
src/api/app/controllers/application_controller.rb

Summary

Maintainability
B
5 hrs
Test Coverage
A
94%

Class ApplicationController has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

class ApplicationController < ActionController::Base
  include Pundit::Authorization
  protect_from_forgery

  include ActionController::ImplicitRender
Severity: Minor
Found in src/api/app/controllers/application_controller.rb - About 2 hrs to fix

    Method gather_exception_defaults has a Cognitive Complexity of 14 (exceeds 8 allowed). Consider refactoring.
    Open

      def gather_exception_defaults(opt)
    if opt[:message]
      @summary = opt[:message].to_s
    elsif @exception
      @summary = @exception.message
    Severity: Minor
    Found in src/api/app/controllers/application_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method gather_exception_defaults has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def gather_exception_defaults(opt)
    if opt[:message]
      @summary = opt[:message].to_s
    elsif @exception
      @summary = @exception.message
    Severity: Minor
    Found in src/api/app/controllers/application_controller.rb - About 1 hr to fix

      Method validate_params has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring.
      Open

        def validate_params
    params.each do |key, value|
      next if value.nil?
      next if key == 'xmlhash' # perfectly fine
      raise InvalidParameterError, "Parameter #{key} has non String class #{value.class}" unless value.is_a?(String)
      Severity: Minor
      Found in src/api/app/controllers/application_controller.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status