Sign upLogin

openSUSE/open-build-service

View on GitHub
Star
src/api/app/controllers/concerns/backend_proxy.rb

Summary

Maintainability
A
0 mins
Test Coverage
C
75%

Method pass_to_backend has a Cognitive Complexity of 14 (exceeds 8 allowed). Consider refactoring.
Wontfix

    def pass_to_backend(path = nil)
      path ||= get_request_path

      if request.get? || request.head?
        volley_backend_path(path) unless forward_from_backend(path)
Severity: Minor
Found in src/api/app/controllers/concerns/backend_proxy.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method forward_from_backend has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

  def forward_from_backend(path)
    # apache & mod_xforward case
    # https://build.opensuse.org/package/show/OBS:Server:Unstable/apache2-mod_xforward
    if CONFIG['use_xforward'] && CONFIG['use_xforward'] != 'false'
      logger.debug "[backend] VOLLEY(mod_xforward): #{path}"
Severity: Minor
Found in src/api/app/controllers/concerns/backend_proxy.rb - About 1 hr to fix

    There are no issues that match your filters.

    Category
    Status