Sign upLogin

openSUSE/open-build-service

View on GitHub
Star
src/api/app/controllers/person_controller.rb

Summary

Maintainability
C
1 day
Test Coverage
B
81%

Method put_userinfo has a Cognitive Complexity of 18 (exceeds 8 allowed). Consider refactoring.
Open

  def put_userinfo
    login = params[:login]
    user = User.find_by_login(login) if login

    unless ::Configuration.accounts_editable?(user)
Severity: Minor
Found in src/api/app/controllers/person_controller.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method internal_register has a Cognitive Complexity of 18 (exceeds 8 allowed). Consider refactoring.
Open

  def internal_register
    if ::Configuration.ldap_enabled?
      render_error(
        status: 403,
        errorcode: 'permission_denied',
Severity: Minor
Found in src/api/app/controllers/person_controller.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method put_userinfo has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def put_userinfo
    login = params[:login]
    user = User.find_by_login(login) if login

    unless ::Configuration.accounts_editable?(user)
Severity: Minor
Found in src/api/app/controllers/person_controller.rb - About 1 hr to fix

    Method post_userinfo has a Cognitive Complexity of 16 (exceeds 8 allowed). Consider refactoring.
    Open

      def post_userinfo
    authorize @user, :update?

    login = params[:login]
    # just for permission checking
    Severity: Minor
    Found in src/api/app/controllers/person_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method post_userinfo has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def post_userinfo
    authorize @user, :update?

    login = params[:login]
    # just for permission checking
    Severity: Minor
    Found in src/api/app/controllers/person_controller.rb - About 1 hr to fix

      Method internal_register has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def internal_register
    if ::Configuration.ldap_enabled?
      render_error(
        status: 403,
        errorcode: 'permission_denied',
      Severity: Minor
      Found in src/api/app/controllers/person_controller.rb - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status