Sign upLogin

openSUSE/open-build-service

View on GitHub
Star
src/api/app/controllers/request_controller.rb

Summary

Maintainability
A
3 hrs
Test Coverage
A
96%

Method request_command_diff has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def request_command_diff
    req = BsRequest.find_by_number!(params[:id])
    superseded_request = req.superseding.find_by_number(params[:diff_to_superseded])
    if params[:diff_to_superseded].present? && superseded_request.blank?
      msg = "Request #{params[:diff_to_superseded]} does not exist or is not superseded by request #{req.number}."
Severity: Minor
Found in src/api/app/controllers/request_controller.rb - About 1 hr to fix

    Method request_command_diff has a Cognitive Complexity of 14 (exceeds 8 allowed). Consider refactoring.
    Open

      def request_command_diff
    req = BsRequest.find_by_number!(params[:id])
    superseded_request = req.superseding.find_by_number(params[:diff_to_superseded])
    if params[:diff_to_superseded].present? && superseded_request.blank?
      msg = "Request #{params[:diff_to_superseded]} does not exist or is not superseded by request #{req.number}."
    Severity: Minor
    Found in src/api/app/controllers/request_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status