Sign upLogin

openSUSE/open-build-service

View on GitHub
Star
src/api/app/controllers/webui/kiwi/images_controller.rb

Summary

Maintainability
A
2 hrs
Test Coverage
B
80%

Method image_params has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def image_params
        preferences_attributes = %i[
          id
          type_image
          type_containerconfig_name
Severity: Minor
Found in src/api/app/controllers/webui/kiwi/images_controller.rb - About 1 hr to fix

    Method import_from_package has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring.
    Open

          def import_from_package
        package = Package.find(params[:package_id])

        kiwi_file = package.kiwi_image_file
    Severity: Minor
    Found in src/api/app/controllers/webui/kiwi/images_controller.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status