Sign upLogin

openSUSE/open-build-service

View on GitHub
Star
src/api/app/controllers/webui/webui_controller.rb

Summary

Maintainability
A
3 hrs
Test Coverage
A
92%

Class WebuiController has 25 methods (exceeds 20 allowed). Consider refactoring.
Open

class Webui::WebuiController < ActionController::Base
  layout 'webui/webui'

  Rails.cache.set_domain if Rails.cache.respond_to?(:set_domain)
Severity: Minor
Found in src/api/app/controllers/webui/webui_controller.rb - About 2 hrs to fix

    Method check_displayed_user has a Cognitive Complexity of 12 (exceeds 8 allowed). Consider refactoring.
    Wontfix

      def check_displayed_user
    param_login = params[:login] || params[:user_login]
    if param_login.present?
      begin
        @displayed_user = User.find_by_login!(param_login)
    Severity: Minor
    Found in src/api/app/controllers/webui/webui_controller.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method kerberos_auth has a Cognitive Complexity of 10 (exceeds 8 allowed). Consider refactoring.
    Open

      def kerberos_auth
    return true unless CONFIG['kerberos_mode'] && !User.session

    authorization = authenticator.authorization_infos || []
    if authorization[0].to_s == 'Negotiate'
    Severity: Minor
    Found in src/api/app/controllers/webui/webui_controller.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status