Sign upLogin

openSUSE/open-build-service

View on GitHub
Star
src/api/app/jobs/update_released_binaries_job.rb

Summary

Maintainability
C
1 day
Test Coverage
A
93%

Method update_binary_releases_for_repository has a Cognitive Complexity of 53 (exceeds 8 allowed). Consider refactoring.
Open

  def update_binary_releases_for_repository(repository, new_binary_releases, time = Time.now)
    # building a hash to avoid single SQL select calls slowing us down too much
    old_binary_releases = {}
    BinaryRelease.transaction do
      repository.binary_releases.current.unchanged.find_each do |binary|
Severity: Minor
Found in src/api/app/jobs/update_released_binaries_job.rb - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update_binary_releases_for_repository has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def update_binary_releases_for_repository(repository, new_binary_releases, time = Time.now)
    # building a hash to avoid single SQL select calls slowing us down too much
    old_binary_releases = {}
    BinaryRelease.transaction do
      repository.binary_releases.current.unchanged.find_each do |binary|
Severity: Major
Found in src/api/app/jobs/update_released_binaries_job.rb - About 2 hrs to fix

    There are no issues that match your filters.

    Category
    Status