Sign upLogin

openSUSE/open-build-service

View on GitHub
Star
src/api/app/lib/authenticator.rb

Summary

Maintainability
A
1 hr
Test Coverage
A
95%

Method extract_krb_user has a Cognitive Complexity of 10 (exceeds 8 allowed). Consider refactoring.
Open

  def extract_krb_user(authorization)
    unless authorization[1]
      Rails.logger.debug "Didn't receive any negotiation data."
      raise_and_invalidate(authorization, 'GSSAPI negotiation failed.')
    end
Severity: Minor
Found in src/api/app/lib/authenticator.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method check_extracted_user has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring.
Open

  def check_extracted_user
    unless @http_user
      if @login.blank?
        return true if check_for_anonymous_user
Severity: Minor
Found in src/api/app/lib/authenticator.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status