Sign upLogin

openSUSE/open-build-service

View on GitHub
Star
src/api/app/models/bs_request_action/differ/query_builder.rb

Summary

Maintainability
A
3 hrs
Test Coverage
A
100%

Method build has a Cognitive Complexity of 18 (exceeds 8 allowed). Consider refactoring.
Open

      def build
        # the target is by default the _link target
        # maintenance_release creates new packages instance, but are changing the source only according to the link
        provided_in_other_action = check_for_local_linked_packages(source_package)
        # fallback name as last resort
Severity: Minor
Found in src/api/app/models/bs_request_action/differ/query_builder.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method build has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def build
        # the target is by default the _link target
        # maintenance_release creates new packages instance, but are changing the source only according to the link
        provided_in_other_action = check_for_local_linked_packages(source_package)
        # fallback name as last resort
Severity: Minor
Found in src/api/app/models/bs_request_action/differ/query_builder.rb - About 1 hr to fix

    Method check_for_local_linked_packages has a Cognitive Complexity of 10 (exceeds 8 allowed). Consider refactoring.
    Open

          def check_for_local_linked_packages(spkg)
        # the target is by default the _link target
        # maintenance_release creates new packages instance, but are changing the source only according to the link
        return if action.target_package && action.action_type == :maintenance_incident
    Severity: Minor
    Found in src/api/app/models/bs_request_action/differ/query_builder.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status