Sign upLogin

openSUSE/open-build-service

View on GitHub
Star
src/api/app/models/event/request.rb

Summary

Maintainability
A
3 hrs
Test Coverage
A
93%

Class Request has 24 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Request < Base
    self.description = 'Request updated'
    self.abstract_class = true
    payload_keys :author, :comment, :description, :id, :number, :actions, :state, :when, :who, :namespace
    shortenable_key :description
Severity: Minor
Found in src/api/app/models/event/request.rb - About 2 hrs to fix

    Method headers_for_actions has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
    Open

        def headers_for_actions
      ret = {}
      payload['actions'].each_with_index do |a, index|
        suffix = if payload['actions'].length == 1 || index.zero?
                   'X-OBS-Request-Action'
    Severity: Minor
    Found in src/api/app/models/event/request.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status