Sign upLogin

openSUSE/open-build-service

View on GitHub
Star
src/api/app/models/event_subscription/find_for_event.rb

Summary

Maintainability
C
7 hrs
Test Coverage
A
97%

Method subscriptions has a Cognitive Complexity of 41 (exceeds 8 allowed). Consider refactoring.
Open

    def subscriptions(channel = :instant_email)
      receivers_and_subscriptions = {}

      event.class.receiver_roles.each do |receiver_role|
        # Find the users/groups who are receivers for this event
Severity: Minor
Found in src/api/app/models/event_subscription/find_for_event.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method subscriptions has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def subscriptions(channel = :instant_email)
      receivers_and_subscriptions = {}

      event.class.receiver_roles.each do |receiver_role|
        # Find the users/groups who are receivers for this event
Severity: Minor
Found in src/api/app/models/event_subscription/find_for_event.rb - About 1 hr to fix

    Method expand_receivers has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring.
    Open

        def expand_receivers(receivers, channel)
      receivers.inject([]) do |new_receivers, receiver|
        case receiver
        when User
          new_receivers << receiver if receiver.is_active?
    Severity: Minor
    Found in src/api/app/models/event_subscription/find_for_event.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status