Sign upLogin

openSUSE/open-build-service

View on GitHub
Star
src/api/app/models/scm_webhook.rb

Summary

Maintainability
B
4 hrs
Test Coverage
A
100%

Class SCMWebhook has 28 methods (exceeds 20 allowed). Consider refactoring.
Confirmed

class SCMWebhook
  include ActiveModel::Model
  include SCMWebhookInstrumentation # for run_callbacks

  attr_accessor :payload
Severity: Minor
Found in src/api/app/models/scm_webhook.rb - About 3 hrs to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Confirmed

      def new_pull_request?
    (github_pull_request? && @payload[:action] == 'opened') ||
      (gitlab_merge_request? && @payload[:action] == 'open') ||
      (gitea_pull_request? && @payload[:action] == 'opened')
  end
    Severity: Minor
    Found in src/api/app/models/scm_webhook.rb and 2 other locations - About 15 mins to fix
    src/api/app/models/scm_webhook.rb on lines 28..32
    src/api/app/models/scm_webhook.rb on lines 40..44

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Confirmed

      def updated_pull_request?
    (github_pull_request? && @payload[:action] == 'synchronize') ||
      (gitlab_merge_request? && @payload[:action] == 'update') ||
      (gitea_pull_request? && @payload[:action] == 'synchronized')
  end
    Severity: Minor
    Found in src/api/app/models/scm_webhook.rb and 2 other locations - About 15 mins to fix
    src/api/app/models/scm_webhook.rb on lines 22..26
    src/api/app/models/scm_webhook.rb on lines 40..44

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Confirmed

      def reopened_pull_request?
    (github_pull_request? && @payload[:action] == 'reopened') ||
      (gitlab_merge_request? && @payload[:action] == 'reopen') ||
      (gitea_pull_request? && @payload[:action] == 'reopened')
  end
    Severity: Minor
    Found in src/api/app/models/scm_webhook.rb and 2 other locations - About 15 mins to fix
    src/api/app/models/scm_webhook.rb on lines 22..26
    src/api/app/models/scm_webhook.rb on lines 28..32

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status