Sign upLogin

openSUSE/open-build-service

View on GitHub
Star
src/api/app/models/update_notification_events.rb

Summary

Maintainability
A
3 hrs
Test Coverage
C
72%

Method perform has a Cognitive Complexity of 15 (exceeds 8 allowed). Consider refactoring.
Open

  def perform
    if semaphore.locked?
      Rails.logger.debug 'skip lastnotifications, still locked'
      return
    end
Severity: Minor
Found in src/api/app/models/update_notification_events.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create_events has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def create_events
    Event::Base.transaction do
      data = type = nil
      @last.elements('notification') do |e|
        type = e['type']
Severity: Minor
Found in src/api/app/models/update_notification_events.rb - About 1 hr to fix

    Method create_events has a Cognitive Complexity of 12 (exceeds 8 allowed). Consider refactoring.
    Open

      def create_events
    Event::Base.transaction do
      data = type = nil
      @last.elements('notification') do |e|
        type = e['type']
    Severity: Minor
    Found in src/api/app/models/update_notification_events.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status