Sign upLogin

opensistemas-hub/osbrain

View on GitHub
Star

Showing 42 of 42 total issues

File agent.py has 1849 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""
Core agent classes.
"""
import contextlib
import errno
Severity: Major
Found in osbrain/agent.py - About 5 days to fix

    Agent has 84 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Agent:
    """
    A base agent class which is to be served by an AgentProcess.

    An AgentProcess runs a Pyro multiplexed server and serves one Agent
    Severity: Major
    Found in osbrain/agent.py - About 1 day to fix

      File address.py has 394 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      """
Implementation of address-related features.
"""
from ipaddress import ip_address
      Severity: Minor
      Found in osbrain/address.py - About 5 hrs to fix

        File proxy.py has 379 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        """
Implementation of proxy-related features.
"""
import os
import sys
        Severity: Minor
        Found in osbrain/proxy.py - About 5 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def __new__(cls, kind):
        if kind not in cls.TWIN.keys():
            raise ValueError('Invalid address kind "%s"!' % kind)
        return super().__new__(cls, kind)
          Severity: Major
          Found in osbrain/address.py and 1 other location - About 1 hr to fix
          osbrain/address.py on lines 380..383

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def __new__(cls, kind):
        if kind not in cls.TWIN.keys():
            raise ValueError('Invalid channel kind "%s"!' % kind)
        return super().__new__(cls, kind)
          Severity: Major
          Found in osbrain/address.py and 1 other location - About 1 hr to fix
          osbrain/address.py on lines 154..157

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function run_agent has 8 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def run_agent(
          Severity: Major
          Found in osbrain/agent.py - About 1 hr to fix

            Function _pyroInvoke has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def _pyroInvoke(  # noqa: N802
            Severity: Major
            Found in osbrain/proxy.py - About 50 mins to fix

              Function __init__ has 7 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def __init__(
              Severity: Major
              Found in osbrain/agent.py - About 50 mins to fix

                Function _bind_channel has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def _bind_channel(
                Severity: Minor
                Found in osbrain/agent.py - About 45 mins to fix

                  Function _send_channel_sync_sub has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      def _send_channel_sync_sub(
                  Severity: Minor
                  Found in osbrain/agent.py - About 45 mins to fix

                    Function logger_received has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                    def logger_received(
    logger, message, log_name='log_history_info', position=None, timeout=1.0
):
    """
    Check if a logger receives a message.
                    Severity: Minor
                    Found in osbrain/helper.py - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function _remote_call has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        def _remote_call(
                    Severity: Minor
                    Found in osbrain/proxy.py - About 45 mins to fix

                      Function find_obj has 6 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          def find_obj(self, env, modname, classname, name, type, searchmode=0):
                      Severity: Minor
                      Found in docs/source/conf.py - About 45 mins to fix

                        Function _get_unique_external_zmq_sockets has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                        Open

                            def _get_unique_external_zmq_sockets(self):
        """
        Return an iterable containing all the zmq.Socket objects from
        `self.socket` which are not internal, without repetition.
                        Severity: Minor
                        Found in osbrain/agent.py - About 45 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function _send_channel has 6 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            def _send_channel(self, channel, message, topic, handler, wait, on_error):
                        Severity: Minor
                        Found in osbrain/agent.py - About 45 mins to fix

                          Function bind has 6 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              def bind(
                          Severity: Minor
                          Found in osbrain/agent.py - About 45 mins to fix

                            Function _bind_address has 6 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                def _bind_address(
                            Severity: Minor
                            Found in osbrain/agent.py - About 45 mins to fix

                              Function send has 6 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                  def send(
                              Severity: Minor
                              Found in osbrain/agent.py - About 45 mins to fix

                                Identical blocks of code found in 2 locations. Consider refactoring.
                                Open

                                    for i in range(10):
        bob.send('main', i)
        reply = bob.recv('main')
        print(reply)
                                Severity: Minor
                                Found in examples/req_rep.py and 1 other location - About 40 mins to fix
                                examples/req_rep_lambda.py on lines 13..16

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 34.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Severity
                                Category
                                Status
                                Source
                                Language