opensistemas-hub/osbrain

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    for i in range(10):
        bob.send('main', i)
        reply = bob.recv('main')
        print(reply)

Found in examples/req_rep_lambda.py and 1 other location - About 40 mins to fix

Read up
Read up

examples/req_rep.py on lines 18..21

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 34.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Function `init` has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(self, transport, address, kind, role, serializer):

Found in osbrain/address.py - About 35 mins to fix

Function `wait_condition` has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def wait_condition(condition, *args, negate=False, timeout=3, **kwargs):

Found in osbrain/helper.py - About 35 mins to fix

Function `logger_received` has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def logger_received(

Found in osbrain/helper.py - About 35 mins to fix

Function `_send_channel_async_rep` has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def _send_channel_async_rep(

Found in osbrain/agent.py - About 35 mins to fix

Function `init` has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(

Found in osbrain/agent.py - About 35 mins to fix

Function `attribute_match_all` has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def attribute_match_all(

Found in osbrain/helper.py - About 35 mins to fix

Function `each` has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def each(self, period, method, *args, alias=None, **kwargs):

Found in osbrain/agent.py - About 35 mins to fix

Function `wait_agent_condition` has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def wait_agent_condition(agent, condition, *args, timeout=3, **kwargs):

Found in osbrain/helper.py - About 35 mins to fix

Function `after` has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def after(self, delay, method, *args, alias=None, **kwargs):

Found in osbrain/agent.py - About 35 mins to fix

Function `random_nameserver_process` has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def random_nameserver_process(

Found in osbrain/nameserver.py - About 35 mins to fix

Function `_bind_channel` has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def _bind_channel(
        self,
        kind,
        alias=None,
        handler=None,

Found in osbrain/agent.py - About 35 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many `return` statements within this function.
Open

    return True

Found in osbrain/helper.py - About 30 mins to fix

Function `_cleanup_ipc_socket_files` has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def _cleanup_ipc_socket_files(self, address):
        """
        Make sure no IPC socket files are left in the file system.
        """
        if isinstance(address, AgentChannel):

Found in osbrain/agent.py - About 25 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `shutdown_agents` has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def shutdown_agents(self, timeout=10.0):
        """
        Shutdown all agents registered in the name server.

        Parameters

Found in osbrain/proxy.py - About 25 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `_common_address_to_host_port` has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def _common_address_to_host_port(addr):
    """
    Try to convert an address to a (host, port) tuple.

    This function is meant to be used with well-known types. For a more

Found in osbrain/address.py - About 25 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `agent_dies` has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def agent_dies(agent, nsproxy, timeout=1.0):
    """
    Check if an agent dies within a given period.

    Parameters

Found in osbrain/helper.py - About 25 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `attribute_match_all` has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def attribute_match_all(
    attribute, length=None, data=None, value=None, endswith=None
):
    """
    Check if an attribute matches all of the following specified conditions:

Found in osbrain/helper.py - About 25 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `unsubscribe` has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def unsubscribe(self, alias: str, topic: Union[bytes, str]) -> None:
        """
        Unsubscribe a SUB/SYNC_SUB socket given by its alias from a given
        specific topic, and delete its entry from the handlers dictionary.

Found in osbrain/agent.py - About 25 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `async_shutdown_agents` has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def async_shutdown_agents(self, nsaddr):
        """
        Shutdown all agents registered in the name server.
        """
        for name in self.agents():

Found in osbrain/nameserver.py - About 25 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading