opensistemas-hub/osbrain

View on GitHub
osbrain/address.py

Summary

Maintainability
C
1 day
Test Coverage

File address.py has 394 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""
Implementation of address-related features.
"""
from ipaddress import ip_address

Severity: Minor
Found in osbrain/address.py - About 5 hrs to fix

    Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(self, transport, address, kind, role, serializer):
    Severity: Minor
    Found in osbrain/address.py - About 35 mins to fix

      Function _common_address_to_host_port has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      def _common_address_to_host_port(addr):
          """
          Try to convert an address to a (host, port) tuple.
      
          This function is meant to be used with well-known types. For a more
      Severity: Minor
      Found in osbrain/address.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          def __new__(cls, kind):
              if kind not in cls.TWIN.keys():
                  raise ValueError('Invalid channel kind "%s"!' % kind)
              return super().__new__(cls, kind)
      Severity: Major
      Found in osbrain/address.py and 1 other location - About 1 hr to fix
      osbrain/address.py on lines 154..157

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          def __new__(cls, kind):
              if kind not in cls.TWIN.keys():
                  raise ValueError('Invalid address kind "%s"!' % kind)
              return super().__new__(cls, kind)
      Severity: Major
      Found in osbrain/address.py and 1 other location - About 1 hr to fix
      osbrain/address.py on lines 380..383

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status