Sign upLogin

oppia/oppia

View on GitHub
Star

Showing 10,737 of 10,737 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

describe('UnicodeStringEditorComponent', () => {
  let component: UnicodeStringEditorComponent;
  let fixture: ComponentFixture<UnicodeStringEditorComponent>;
  let externalSaveService: ExternalSaveService;
Severity: Major
Found in extensions/objects/templates/unicode-string-editor.component.spec.ts and 1 other location - About 1 wk to fix
extensions/objects/templates/normalized-string-editor.component.spec.ts on lines 25..225

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 1516.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

describe('NormalizedStringEditorComponent', () => {
  let component: NormalizedStringEditorComponent;
  let fixture: ComponentFixture<NormalizedStringEditorComponent>;
  let externalSaveService: ExternalSaveService;
Severity: Major
Found in extensions/objects/templates/normalized-string-editor.component.spec.ts and 1 other location - About 1 wk to fix
extensions/objects/templates/unicode-string-editor.component.spec.ts on lines 25..225

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 1516.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File exp_services.py has 3210 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# coding: utf-8
#
# Copyright 2014 The Oppia Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
Severity: Major
Found in core/domain/exp_services.py - About 1 wk to fix

    File gae_models_test.py has 3209 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    # coding: utf-8
#
# Copyright 2014 The Oppia Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
    Severity: Major
    Found in core/storage/user/gae_models_test.py - About 1 wk to fix

      File reader_test.py has 3137 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      # Copyright 2014 The Oppia Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
      Severity: Major
      Found in core/controllers/reader_test.py - About 1 wk to fix

        File suggestion_test.py has 3134 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        # coding: utf-8
#
# Copyright 2018 The Oppia Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
        Severity: Major
        Found in core/controllers/suggestion_test.py - About 1 wk to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            describe('when viewing suggestion', function () {
    const reviewable = false;
    const subheading = 'topic_1 / story_1 / chapter_1';

    const suggestion1 = {
          Severity: Major
          Found in core/templates/pages/contributor-dashboard-page/modal-templates/translation-suggestion-review-modal.component.spec.ts and 1 other location - About 1 wk to fix
          core/templates/pages/contributor-dashboard-page/modal-templates/translation-suggestion-review-modal.component.spec.ts on lines 2127..2335

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 1430.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            describe('when viewing suggestion', function () {
    const reviewable = false;
    const subheading = 'topic_1 / story_1 / chapter_1';

    const suggestion1 = {
          Severity: Major
          Found in core/templates/pages/contributor-dashboard-page/modal-templates/translation-suggestion-review-modal.component.spec.ts and 1 other location - About 1 wk to fix
          core/templates/pages/contributor-dashboard-page/modal-templates/translation-suggestion-review-modal.component.spec.ts on lines 1917..2125

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 1430.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          File editor_test.py has 3065 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          # coding: utf-8

# Copyright 2014 The Oppia Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
          Severity: Major
          Found in core/controllers/editor_test.py - About 1 wk to fix

            File gae_models.py has 2986 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            # Copyright 2018 The Oppia Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
            Severity: Major
            Found in core/storage/suggestion/gae_models.py - About 1 wk to fix

              File parser.js has 2862 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              module.exports = (function() {
  /*
   * Generated by PEG.js 0.8.0.
   *
   * http://pegjs.majda.cz/
              Severity: Major
              Found in core/templates/expressions/parser.js - About 1 wk to fix

                File conversation-skin.component.spec.ts has 2759 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                // Copyright 2022 The Oppia Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
                Severity: Major
                Found in core/templates/pages/exploration-player-page/learner-experience/conversation-skin.component.spec.ts - About 1 wk to fix

                  File topic_services_test.py has 2752 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  # coding: utf-8
#
# Copyright 2018 The Oppia Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
                  Severity: Major
                  Found in core/domain/topic_services_test.py - About 1 wk to fix

                    File gae_models.py has 2657 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    # coding: utf-8
#
# Copyright 2014 The Oppia Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
                    Severity: Major
                    Found in core/storage/user/gae_models.py - About 1 wk to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                            var svmData = {
        classes: [0, 1],
        kernel_params: {
          kernel: 'rbf',
          coef0: 0.0,
                      Severity: Major
                      Found in extensions/classifiers/svm-prediction.service.spec.ts and 1 other location - About 1 wk to fix
                      extensions/classifiers/svm-prediction.service.spec.ts on lines 307..502

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 1215.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                            var svmData = {
        classes: [0, 1],
        kernel_params: {
          kernel: 'rbf',
          coef0: 0.0,
                      Severity: Major
                      Found in extensions/classifiers/svm-prediction.service.spec.ts and 1 other location - About 1 wk to fix
                      extensions/classifiers/svm-prediction.service.spec.ts on lines 78..273

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 1215.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      File admin_test.py has 2564 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      # Copyright 2014 The Oppia Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
                      Severity: Major
                      Found in core/controllers/admin_test.py - About 1 wk to fix

                        File image-editor.component.spec.ts has 2469 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        // Copyright 2021 The Oppia Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
                        Severity: Major
                        Found in extensions/objects/templates/image-editor.component.spec.ts - About 6 days to fix

                          File stats_services_test.py has 2434 lines of code (exceeds 250 allowed). Consider refactoring.
                          Open

                          # coding: utf-8
#
# Copyright 2014 The Oppia Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
                          Severity: Major
                          Found in core/domain/stats_services_test.py - About 6 days to fix

                            File user_services.py has 2424 lines of code (exceeds 250 allowed). Consider refactoring.
                            Open

                            # coding: utf-8
#
# Copyright 2014 The Oppia Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
                            Severity: Major
                            Found in core/domain/user_services.py - About 6 days to fix
                              Severity
                              Category
                              Status
                              Source
                              Language