Sign upLogin

oppia/oppia

View on GitHub
Star

Showing 10,737 of 10,737 total issues

File reader.py has 2359 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Copyright 2014 The Oppia Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
Severity: Major
Found in core/controllers/reader.py - About 6 days to fix

    File translation-suggestion-review-modal.component.spec.ts has 2346 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    // Copyright 2021 The Oppia Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
    Severity: Major
    Found in core/templates/pages/contributor-dashboard-page/modal-templates/translation-suggestion-review-modal.component.spec.ts - About 6 days to fix

      File pylint_extensions.py has 2337 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      # coding: utf-8
#
# Copyright 2018 The Oppia Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
      Severity: Major
      Found in scripts/linters/pylint_extensions.py - About 6 days to fix

        File contributions-and-review.component.spec.ts has 2287 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        // Copyright 2020 The Oppia Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
        Severity: Major
        Found in core/templates/pages/contributor-dashboard-page/contributions-and-review/contributions-and-review.component.spec.ts - About 6 days to fix

          File story_services_test.py has 2269 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          # Copyright 2018 The Oppia Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
          Severity: Major
          Found in core/domain/story_services_test.py - About 6 days to fix

            File exploration-warnings.service.spec.ts has 2267 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            // Copyright 2020 The Oppia Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
            Severity: Major
            Found in core/templates/pages/exploration-editor-page/services/exploration-warnings.service.spec.ts - About 6 days to fix

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

              describe('Release Coordinator Page Root', () => {
  let fixture: ComponentFixture<ReleaseCoordinatorPageRootComponent>;
  let component: ReleaseCoordinatorPageRootComponent;
  let pageHeadService: PageHeadService;
  let accessValidationBackendApiService: AccessValidationBackendApiService;
              Severity: Major
              Found in core/templates/pages/release-coordinator-page/release-coordinator-page-root.component.spec.ts and 2 other locations - About 6 days to fix
              core/templates/pages/delete-account-page/delete-account-page-root.component.spec.ts on lines 46..175
              core/templates/pages/profile-page/profile-page-root.component.spec.ts on lines 46..175

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 1019.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

              describe('Delete Account Page Root', () => {
  let fixture: ComponentFixture<DeleteAccountPageRootComponent>;
  let component: DeleteAccountPageRootComponent;
  let pageHeadService: PageHeadService;
  let accessValidationBackendApiService: AccessValidationBackendApiService;
              Severity: Major
              Found in core/templates/pages/delete-account-page/delete-account-page-root.component.spec.ts and 2 other locations - About 6 days to fix
              core/templates/pages/profile-page/profile-page-root.component.spec.ts on lines 46..175
              core/templates/pages/release-coordinator-page/release-coordinator-page-root.component.spec.ts on lines 46..176

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 1019.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

              describe('Profile Page Root', () => {
  let fixture: ComponentFixture<ProfilePageRootComponent>;
  let component: ProfilePageRootComponent;
  let pageHeadService: PageHeadService;
  let accessValidationBackendApiService: AccessValidationBackendApiService;
              Severity: Major
              Found in core/templates/pages/profile-page/profile-page-root.component.spec.ts and 2 other locations - About 6 days to fix
              core/templates/pages/delete-account-page/delete-account-page-root.component.spec.ts on lines 46..175
              core/templates/pages/release-coordinator-page/release-coordinator-page-root.component.spec.ts on lines 46..176

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 1019.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              File state-translation.component.spec.ts has 2153 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              // Copyright 2020 The Oppia Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
              Severity: Major
              Found in core/templates/pages/exploration-editor-page/translation-tab/state-translation/state-translation.component.spec.ts - About 5 days to fix

                File story_domain_test.py has 2134 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                # Copyright 2018 The Oppia Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
                Severity: Major
                Found in core/domain/story_domain_test.py - About 5 days to fix

                  File takeout_service_test.py has 2130 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  # Copyright 2018 The Oppia Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
                  Severity: Major
                  Found in core/domain/takeout_service_test.py - About 5 days to fix

                    File stats_domain_test.py has 2128 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    # coding: utf-8
#
# Copyright 2014 The Oppia Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
                    Severity: Major
                    Found in core/domain/stats_domain_test.py - About 5 days to fix

                      File email_manager.py has 2110 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      # coding: utf-8
#
# Copyright 2014 The Oppia Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
                      Severity: Major
                      Found in core/domain/email_manager.py - About 5 days to fix

                        File topic_domain.py has 2066 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        # coding: utf-8
#
# Copyright 2018 The Oppia Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
                        Severity: Major
                        Found in core/domain/topic_domain.py - About 5 days to fix

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                          describe('TranslationCoordinatorRoleEditorModalComponent', () => {
  let component: TranslationCoordinatorRoleEditorModalComponent;
  let fixture: ComponentFixture<TranslationCoordinatorRoleEditorModalComponent>;
  let ngbActiveModal: NgbActiveModal;
  let adminBackendApiService: AdminBackendApiService;
                          Severity: Major
                          Found in core/templates/pages/admin-page/roles-tab/translation-coordinator-role-editor-modal.component.spec.ts and 1 other location - About 5 days to fix
                          core/templates/pages/admin-page/roles-tab/topic-manager-role-editor-modal.component.spec.ts on lines 36..162

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 930.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                          describe('TopicManagerRoleEditorModalComponent', () => {
  let component: TopicManagerRoleEditorModalComponent;
  let fixture: ComponentFixture<TopicManagerRoleEditorModalComponent>;
  let ngbActiveModal: NgbActiveModal;
  let adminBackendApiService: AdminBackendApiService;
                          Severity: Major
                          Found in core/templates/pages/admin-page/roles-tab/topic-manager-role-editor-modal.component.spec.ts and 1 other location - About 5 days to fix
                          core/templates/pages/admin-page/roles-tab/translation-coordinator-role-editor-modal.component.spec.ts on lines 36..164

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 930.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          File story_domain.py has 2020 lines of code (exceeds 250 allowed). Consider refactoring.
                          Open

                          # Copyright 2018 The Oppia Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
                          Severity: Major
                          Found in core/domain/story_domain.py - About 5 days to fix

                            File skill_domain.py has 2013 lines of code (exceeds 250 allowed). Consider refactoring.
                            Open

                            # Copyright 2018 The Oppia Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
                            Severity: Major
                            Found in core/domain/skill_domain.py - About 5 days to fix

                              File draft_upgrade_services_test.py has 1989 lines of code (exceeds 250 allowed). Consider refactoring.
                              Open

                              # coding: utf-8
#
# Copyright 2014 The Oppia Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
                              Severity: Major
                              Found in core/domain/draft_upgrade_services_test.py - About 5 days to fix
                                Severity
                                Category
                                Status
                                Source
                                Language