Sign upLogin

ory-am/hydra

View on GitHub
Star
client/client.go

Summary

Maintainability
C
1 day
Test Coverage

Method Client.GetEffectiveLifespan has a Cognitive Complexity of 37 (exceeds 20 allowed). Consider refactoring.
Open

func (c *Client) GetEffectiveLifespan(gt fosite.GrantType, tt fosite.TokenType, fallback time.Duration) time.Duration {
    var cl *time.Duration
    if gt == fosite.GrantTypeAuthorizationCode {
        if tt == fosite.AccessToken && c.AuthorizationCodeGrantAccessTokenLifespan.Valid {
            cl = &c.AuthorizationCodeGrantAccessTokenLifespan.Duration
Severity: Minor
Found in client/client.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Client has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

type Client struct {
    NID uuid.UUID `db:"nid" faker:"-" json:"-"`

    // OAuth 2.0 Client ID
    //
Severity: Minor
Found in client/client.go - About 2 hrs to fix

    Avoid deeply nested control flow statements.
    Open

            } else if tt == fosite.IDToken && c.ImplicitGrantIDTokenLifespan.Valid {
            cl = &c.ImplicitGrantIDTokenLifespan.Duration
        }
    Severity: Major
    Found in client/client.go - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

          } else if gt == fosite.GrantTypePassword {
        if tt == fosite.AccessToken && c.PasswordGrantAccessTokenLifespan.Valid {
            cl = &c.PasswordGrantAccessTokenLifespan.Duration
        } else if tt == fosite.RefreshToken && c.PasswordGrantRefreshTokenLifespan.Valid {
            cl = &c.PasswordGrantRefreshTokenLifespan.Duration
      Severity: Major
      Found in client/client.go - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                if tt == fosite.AccessToken && c.JwtBearerGrantAccessTokenLifespan.Valid {
            cl = &c.JwtBearerGrantAccessTokenLifespan.Duration
        }
        Severity: Major
        Found in client/client.go - About 45 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if gt == fosite.GrantTypeAuthorizationCode {
        if tt == fosite.AccessToken && c.AuthorizationCodeGrantAccessTokenLifespan.Valid {
            cl = &c.AuthorizationCodeGrantAccessTokenLifespan.Duration
        } else if tt == fosite.IDToken && c.AuthorizationCodeGrantIDTokenLifespan.Valid {
            cl = &c.AuthorizationCodeGrantIDTokenLifespan.Duration
          Severity: Minor
          Found in client/client.go and 1 other location - About 1 hr to fix
          client/client.go on lines 544..552

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 128.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              } else if gt == fosite.GrantTypeRefreshToken {
        if tt == fosite.AccessToken && c.RefreshTokenGrantAccessTokenLifespan.Valid {
            cl = &c.RefreshTokenGrantAccessTokenLifespan.Duration
        } else if tt == fosite.IDToken && c.RefreshTokenGrantIDTokenLifespan.Valid {
            cl = &c.RefreshTokenGrantIDTokenLifespan.Duration
          Severity: Minor
          Found in client/client.go and 1 other location - About 1 hr to fix
          client/client.go on lines 516..552

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 128.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status