Sign upLogin

ory-am/hydra

View on GitHub
Star
client/validator.go

Summary

Maintainability
D
1 day
Test Coverage

Method Validator.Validate has a Cognitive Complexity of 68 (exceeds 20 allowed). Consider refactoring.
Open

func (v *Validator) Validate(ctx context.Context, c *Client) error {
    if c.TokenEndpointAuthMethod == "" {
        c.TokenEndpointAuthMethod = "client_secret_basic"
    } else if c.TokenEndpointAuthMethod == "private_key_jwt" {
        if len(c.JSONWebKeysURI) == 0 && c.JSONWebKeys == nil {
Severity: Minor
Found in client/validator.go - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Validator.Validate has 117 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (v *Validator) Validate(ctx context.Context, c *Client) error {
    if c.TokenEndpointAuthMethod == "" {
        c.TokenEndpointAuthMethod = "client_secret_basic"
    } else if c.TokenEndpointAuthMethod == "private_key_jwt" {
        if len(c.JSONWebKeysURI) == 0 && c.JSONWebKeys == nil {
Severity: Major
Found in client/validator.go - About 3 hrs to fix

    Method Validator.Validate has 19 return statements (exceeds 4 allowed).
    Open

    func (v *Validator) Validate(ctx context.Context, c *Client) error {
    if c.TokenEndpointAuthMethod == "" {
        c.TokenEndpointAuthMethod = "client_secret_basic"
    } else if c.TokenEndpointAuthMethod == "private_key_jwt" {
        if len(c.JSONWebKeysURI) == 0 && c.JSONWebKeys == nil {
    Severity: Major
    Found in client/validator.go - About 1 hr to fix

      Method Validator.ValidateSectorIdentifierURL has 8 return statements (exceeds 4 allowed).
      Open

      func (v *Validator) ValidateSectorIdentifierURL(ctx context.Context, location string, redirectURIs []string) error {
    l, err := url.Parse(location)
    if err != nil {
        return errorsx.WithStack(ErrInvalidClientMetadata.WithHintf("Value of sector_identifier_uri could not be parsed because %s.", err))
    }
      Severity: Major
      Found in client/validator.go - About 50 mins to fix

        Method Validator.ValidateDynamicRegistration has 5 return statements (exceeds 4 allowed).
        Open

        func (v *Validator) ValidateDynamicRegistration(ctx context.Context, c *Client) error {
    if c.Metadata != nil {
        return errorsx.WithStack(ErrInvalidClientMetadata.
            WithHint(`"metadata" cannot be set for dynamic client registration`),
        )
        Severity: Major
        Found in client/validator.go - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status