Sign upLogin

ory-am/hydra

View on GitHub
Star
cmd/cmd_create_client.go

Summary

Maintainability
A
2 hrs
Test Coverage

Function NewCreateClientsCommand has 54 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func NewCreateClientsCommand() *cobra.Command {
    cmd := &cobra.Command{
        Use:     "oauth2-client",
        Short:   "Create an OAuth 2.0 Client",
        Aliases: []string{"client"},
Severity: Minor
Found in cmd/cmd_create_client.go - About 1 hr to fix

    Function NewCreateClientsCommand has 6 return statements (exceeds 4 allowed).
    Open

    func NewCreateClientsCommand() *cobra.Command {
    cmd := &cobra.Command{
        Use:     "oauth2-client",
        Short:   "Create an OAuth 2.0 Client",
        Aliases: []string{"client"},
    Severity: Major
    Found in cmd/cmd_create_client.go - About 40 mins to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                  if encryptSecret && client.ClientSecret != nil {
                enc, err := ek.Encrypt([]byte(*client.ClientSecret))
                if err != nil {
                    _, _ = fmt.Fprintf(cmd.ErrOrStderr(), "Failed to encrypt client secret: %s", err)
                    return cmdx.FailSilently(cmd)
      Severity: Major
      Found in cmd/cmd_create_client.go and 2 other locations - About 40 mins to fix
      cmd/cmd_import_client.go on lines 114..122
      cmd/cmd_update_client.go on lines 56..64

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 110.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status