Sign upLogin

ory-am/hydra

View on GitHub
Star
consent/handler.go

Summary

Maintainability
D
2 days
Test Coverage

File handler.go has 519 lines of code (exceeds 500 allowed). Consider refactoring.
Open

// Copyright © 2022 Ory Corp
// SPDX-License-Identifier: Apache-2.0

package consent
Severity: Minor
Found in consent/handler.go - About 2 hrs to fix

    Method Handler.acceptOAuth2LoginRequest has 69 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (h *Handler) acceptOAuth2LoginRequest(w http.ResponseWriter, r *http.Request, _ httprouter.Params) {
    ctx := r.Context()

    challenge := stringsx.Coalesce(
        r.URL.Query().Get("login_challenge"),
    Severity: Minor
    Found in consent/handler.go - About 1 hr to fix

      Method Handler.rejectOAuth2ConsentRequest has 52 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (h *Handler) rejectOAuth2ConsentRequest(w http.ResponseWriter, r *http.Request, _ httprouter.Params) {
    ctx := r.Context()

    challenge := stringsx.Coalesce(
        r.URL.Query().Get("consent_challenge"),
      Severity: Minor
      Found in consent/handler.go - About 1 hr to fix

        Method Handler.rejectOAuth2LoginRequest has 51 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (h *Handler) rejectOAuth2LoginRequest(w http.ResponseWriter, r *http.Request, _ httprouter.Params) {
    ctx := r.Context()

    challenge := stringsx.Coalesce(
        r.URL.Query().Get("login_challenge"),
        Severity: Minor
        Found in consent/handler.go - About 1 hr to fix

          Method Handler.acceptOAuth2LoginRequest has 10 return statements (exceeds 4 allowed).
          Open

          func (h *Handler) acceptOAuth2LoginRequest(w http.ResponseWriter, r *http.Request, _ httprouter.Params) {
    ctx := r.Context()

    challenge := stringsx.Coalesce(
        r.URL.Query().Get("login_challenge"),
          Severity: Major
          Found in consent/handler.go - About 1 hr to fix

            Method Handler.rejectOAuth2ConsentRequest has 7 return statements (exceeds 4 allowed).
            Open

            func (h *Handler) rejectOAuth2ConsentRequest(w http.ResponseWriter, r *http.Request, _ httprouter.Params) {
    ctx := r.Context()

    challenge := stringsx.Coalesce(
        r.URL.Query().Get("consent_challenge"),
            Severity: Major
            Found in consent/handler.go - About 45 mins to fix

              Method Handler.rejectOAuth2LoginRequest has 7 return statements (exceeds 4 allowed).
              Open

              func (h *Handler) rejectOAuth2LoginRequest(w http.ResponseWriter, r *http.Request, _ httprouter.Params) {
    ctx := r.Context()

    challenge := stringsx.Coalesce(
        r.URL.Query().Get("login_challenge"),
              Severity: Major
              Found in consent/handler.go - About 45 mins to fix

                Method Handler.acceptOAuth2ConsentRequest has 7 return statements (exceeds 4 allowed).
                Open

                func (h *Handler) acceptOAuth2ConsentRequest(w http.ResponseWriter, r *http.Request, _ httprouter.Params) {
    ctx := r.Context()

    challenge := stringsx.Coalesce(
        r.URL.Query().Get("consent_challenge"),
                Severity: Major
                Found in consent/handler.go - About 45 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  func (h *Handler) getOAuth2ConsentRequest(w http.ResponseWriter, r *http.Request, _ httprouter.Params) {
    challenge := stringsx.Coalesce(
        r.URL.Query().Get("consent_challenge"),
        r.URL.Query().Get("challenge"),
    )
                  Severity: Major
                  Found in consent/handler.go and 1 other location - About 4 hrs to fix
                  consent/handler.go on lines 344..377

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 323.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  func (h *Handler) getOAuth2LoginRequest(w http.ResponseWriter, r *http.Request, _ httprouter.Params) {
    challenge := stringsx.Coalesce(
        r.URL.Query().Get("login_challenge"),
        r.URL.Query().Get("challenge"),
    )
                  Severity: Major
                  Found in consent/handler.go and 1 other location - About 4 hrs to fix
                  consent/handler.go on lines 652..684

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 323.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status