Sign upLogin

ory-am/hydra

View on GitHub
Star
oauth2/oauth2_refresh_token_test.go

Summary

Maintainability
D
1 day
Test Coverage

Function TestCreateRefreshTokenSessionStress has a Cognitive Complexity of 64 (exceeds 20 allowed). Consider refactoring.
Open

func TestCreateRefreshTokenSessionStress(t *testing.T) {
    if testing.Short() {
        return
    }
Severity: Minor
Found in oauth2/oauth2_refresh_token_test.go - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function TestCreateRefreshTokenSessionStress has 150 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func TestCreateRefreshTokenSessionStress(t *testing.T) {
    if testing.Short() {
        return
    }
Severity: Major
Found in oauth2/oauth2_refresh_token_test.go - About 5 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                                switch dbName {
                            case dbal.DriverMySQL:
                            case dbal.DriverPostgreSQL, dbal.DriverCockroachDB:
                                var matched bool
                                for _, errSubstr := range []string{
    Severity: Major
    Found in oauth2/oauth2_refresh_token_test.go - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                                  if dbName != dbal.DriverMySQL {
                                t.Errorf("an unexpected RFC6749 error with the name %q was returned.\n"+
                                    "Hint: has the refresh token error handling changed in fosite? If so, you need to add further "+
                                    "assertions here to cover the additional errors that are being returned by the handler.\n"+
                                    "DB version: %s\n"+
      Severity: Major
      Found in oauth2/oauth2_refresh_token_test.go - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status