Sign upLogin

otiai10/amesh-bot

View on GitHub
Star
commands/forecast.go

Summary

Maintainability
B
5 hrs
Test Coverage

Method ForecastCommand.FormatForecastToSlackBlocks has a Cognitive Complexity of 38 (exceeds 20 allowed). Consider refactoring.
Open

func (cmd ForecastCommand) FormatForecastToSlackBlocks(entries []api.ComprehensiveForecastEntry, overview *api.OverviewForecast) (blocks []slack.Block) {

    k := 0 // まずは一番うえのAreaだけ見る, which means 伊豆諸島・小笠原諸島を無視している

    // {{{ エリア「k」における情報をまず抽出
Severity: Minor
Found in commands/forecast.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method ForecastCommand.FormatForecastToSlackBlocks has 74 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (cmd ForecastCommand) FormatForecastToSlackBlocks(entries []api.ComprehensiveForecastEntry, overview *api.OverviewForecast) (blocks []slack.Block) {

    k := 0 // まずは一番うえのAreaだけ見る, which means 伊豆諸島・小笠原諸島を無視している

    // {{{ エリア「k」における情報をまず抽出
Severity: Minor
Found in commands/forecast.go - About 1 hr to fix

    Method ForecastCommand.Execute has 7 return statements (exceeds 4 allowed).
    Open

    func (cmd ForecastCommand) Execute(ctx context.Context, client service.ISlackClient, event slackevents.AppMentionEvent) error {
    city := "tokyo"
    list := false
    help := bytes.NewBuffer(nil)
    fset := largo.NewFlagSet("forecast", largo.ContinueOnError)
    Severity: Major
    Found in commands/forecast.go - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status