Sign upLogin

otiai10/amesh-bot

View on GitHub
Star
service/slack.go

Summary

Maintainability
C
1 day
Test Coverage

Method SlackClient.PostMessage has 7 return statements (exceeds 4 allowed).
Open

func (c *SlackClient) PostMessage(ctx context.Context, msg interface{}) (*PostMessageResponse, error) {
    body := bytes.NewBuffer(nil)
    if err := json.NewEncoder(body).Encode(msg); err != nil {
        return nil, err
    }
Severity: Major
Found in service/slack.go - About 45 mins to fix

    Method SlackClient.DeleteMessage has 7 return statements (exceeds 4 allowed).
    Open

    func (c *SlackClient) DeleteMessage(ctx context.Context, msg interface{}) error {

    body := bytes.NewBuffer(nil)
    if err := json.NewEncoder(body).Encode(msg); err != nil {
        return err
    Severity: Major
    Found in service/slack.go - About 45 mins to fix

      Method SlackClient.UpdateMessage has 7 return statements (exceeds 4 allowed).
      Open

      func (c *SlackClient) UpdateMessage(ctx context.Context, msg interface{}) error {

    body := bytes.NewBuffer(nil)
    if err := json.NewEncoder(body).Encode(msg); err != nil {
        return err
      Severity: Major
      Found in service/slack.go - About 45 mins to fix

        Method SlackClient.GetThreadHistory has 6 return statements (exceeds 4 allowed).
        Open

        func (c *SlackClient) GetThreadHistory(ctx context.Context, channel, thread string) ([]slack.Msg, error) {
    // api := slack.New(c.AccessToken)
    // api.GetConversationRepliesContext(ctx, &slack.GetConversationRepliesParameters{})
    query := url.Values{"channel": []string{channel}, "ts": []string{thread}}
    req, err := http.NewRequest("GET", "https://slack.com/api/conversations.replies?"+query.Encode(), nil)
        Severity: Major
        Found in service/slack.go - About 40 mins to fix

          Method SlackClient.GetChannelInfo has 6 return statements (exceeds 4 allowed).
          Open

          func (c *SlackClient) GetChannelInfo(ctx context.Context, id string) (info slack.Channel, err error) {
    req, err := http.NewRequest("GET", "https://slack.com/api/conversations.info?channel="+id, nil)
    if err != nil {
        // return err
        return
          Severity: Major
          Found in service/slack.go - About 40 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func (c *SlackClient) DeleteMessage(ctx context.Context, msg interface{}) error {

    body := bytes.NewBuffer(nil)
    if err := json.NewEncoder(body).Encode(msg); err != nil {
        return err
            Severity: Major
            Found in service/slack.go and 1 other location - About 4 hrs to fix
            service/slack.go on lines 180..217

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 320.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func (c *SlackClient) UpdateMessage(ctx context.Context, msg interface{}) error {

    body := bytes.NewBuffer(nil)
    if err := json.NewEncoder(body).Encode(msg); err != nil {
        return err
            Severity: Major
            Found in service/slack.go and 1 other location - About 4 hrs to fix
            service/slack.go on lines 141..178

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 320.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status