outcastgeek/jrzmq

View on GitHub
zguide/titanic.rb

Summary

Maintainability
A
25 mins
Test Coverage

Method service_success has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def service_success client, uuid
  # Attempt to process a single request, return True if successful
  return true unless File.exist?(request_filename(uuid))

  request = JSON.parse(File.read(request_filename(uuid)))
Severity: Minor
Found in zguide/titanic.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status