owncloud/core

View on GitHub
apps/files_versions/lib/MetaStorage.php

Summary

Maintainability
A
2 hrs
Test Coverage

Function copyRecursiveMetaDataFiles has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public function copyRecursiveMetaDataFiles(string $src, string $srcOwnerUid, string $dst, string $dstOwnerUid) {
        $absSrc = self::pathToAbsDiskPath($srcOwnerUid, $src);
        $absDst = self::pathToAbsDiskPath($dstOwnerUid, $dst);

        if (!\is_dir($absSrc)) {
Severity: Minor
Found in apps/files_versions/lib/MetaStorage.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function readMetaFile has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    private function readMetaFile(string $diskPath) {
        if (!\file_exists($diskPath)) {
            return [];
        }

Severity: Minor
Found in apps/files_versions/lib/MetaStorage.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method renameOrCopy has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function renameOrCopy(string $op, string $src, string $srcOwnerUid, string $dst, string $dstOwnerUid) {
Severity: Minor
Found in apps/files_versions/lib/MetaStorage.php - About 35 mins to fix

    There are no issues that match your filters.

    Category
    Status