owncloud/core

Method getFile has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function getFile($size) {
        $ext = $this->getExtension();

        $basePath = "{$this->path}/avatar.$ext";

Method findMigrations has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    protected function findMigrations() {
        $directory = \realpath($this->migrationsPath);
        $iterator = new \RegexIterator(
            new \RecursiveIteratorIterator(
                new \RecursiveDirectoryIterator($directory, \FilesystemIterator::SKIP_DOTS),

Method setValues has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function setValues($table, array $keys, array $values, array $updatePreconditionValues = []) {
        // Try to insert whole record into the table ($toInsert) if predicate NOT EXISTS ($compare) is satisfied
        $toInsert = \array_merge($keys, $values);
        $compare = \array_keys($keys);
        $tableName = $this->tablePrefix . $table;

Method processLines has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    private function processLines(array $params, array &$data) {
        static $lastProcessedChar = null;

        if (!isset($data['linesNumber'])) {
            $data = [

Method loginWithCookie has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function loginWithCookie($uid, $currentToken) {
        $this->logger->debug(
            'regenerating session id for uid {uid}, currentToken {currentToken}',
            ['app' => __METHOD__, 'uid' => $uid, 'currentToken' => $currentToken]
        );

Method getNumberOfUnreadCommentsForNodes has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function getNumberOfUnreadCommentsForNodes($objectType, $objectIds, IUser $user) {
        $qbMain = $this->dbConn->getQueryBuilder();
        $qbSup = $this->dbConn->getQueryBuilder();

        $unreadCountsForNodes = [];

Method getTree has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function getTree($id, $limit = 0, $offset = 0) {
        $tree = [];
        $tree['comment'] = $this->get($id);
        $tree['replies'] = [];

Method execute has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    protected function execute(InputInterface $input, OutputInterface $output): int {
        // validate the environment
        $server = \OC::$server;
        $setupHelper = new Setup(
            $this->config,

Method execute has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    protected function execute(InputInterface $input, OutputInterface $output): int {
        $configNames = $input->getArgument('name');
        $configName = $configNames[0];

        if (\sizeof($configNames) > 1) {

Method execute has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    protected function execute(InputInterface $input, OutputInterface $output): int {
        '@phan-var \OC\Files\MimetypeDetector $this->mimetypeDetector';
        $mappings = $this->mimetypeDetector->getAllMappings();

        $totalFilecacheUpdates = 0;

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    public function rename($path1, $path2) {
        if (!$this->isReadable($path1)) {
            return false;
        }
        if ($this->file_exists($path2)) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    public function copy($path1, $path2) {
        if (!$this->isReadable($path1)) {
            return false;
        }
        if ($this->file_exists($path2)) {

• Read up
  Read up

Consider simplifying this complex logical expression.

Open

            if (
            $.inArray(keyCodes.n, keys) !== -1 && ($.inArray(keyCodes.cmdFirefox, keys) !== -1 || $.inArray(keyCodes.cmdOpera, keys) !== -1 || $.inArray(keyCodes.leftCmdWebKit, keys) !== -1 || $.inArray(keyCodes.rightCmdWebKit, keys) !== -1 || $.inArray(keyCodes.ctrl, keys) !== -1 || event.ctrlKey)) {
                if ($.inArray(keyCodes.shift, keys) !== -1) { //16=shift, New File
                    newFile();
                } else { //New Folder

Consider simplifying this complex logical expression.

Open

            if (
            $.inArray(keyCodes.n, keys) !== -1 && ($.inArray(keyCodes.cmdFirefox, keys) !== -1 || $.inArray(keyCodes.cmdOpera, keys) !== -1 || $.inArray(keyCodes.leftCmdWebKit, keys) !== -1 || $.inArray(keyCodes.rightCmdWebKit, keys) !== -1 || $.inArray(keyCodes.ctrl, keys) !== -1 || event.ctrlKey)) {
                preventDefault = true; //new file/folder prevent browser from responding
            }

Function prompt has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

    prompt: function (text, title, callback, modal, name, password, buttonDeclineText, buttonConfirmText) {

Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

        $appName,
        IRequest $request,
        IL10N $l10n,
        IConfig $config,
        Session $userSession,

Method setMailSettings has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

        $mail_domain,
        $mail_from_address,
        $mail_smtpmode,
        $mail_smtpsecure,
        $mail_smtphost,

Method addShare has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

    public function addShare($remote, $token, $password, $name, $owner, $accepted = false, $user = null, $remoteId = -1) {

Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

        IRootFolder $rootFolder,
        IUrlGenerator $urlGenerator,
        EventDispatcher $eventDispatcher,
        \OCP\Share\IManager $shareManager,
        NotificationPublisher $notificationPublisher,

Consider simplifying this complex logical expression.

Open

            if ($newPermissions !== null &&
                $newPermissions !== Constants::PERMISSION_READ &&
                $newPermissions !== Constants::PERMISSION_CREATE &&
                $newPermissions !== (Constants::PERMISSION_READ | Constants::PERMISSION_UPDATE) &&
                $newPermissions !== (Constants::PERMISSION_READ | Constants::PERMISSION_CREATE) &&