Sign upLogin

owncloud/core

View on GitHub
Star
lib/private/Route/Router.php

Summary

Maintainability
D
1 day
Test Coverage

Function match has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

    public function match($url) {
        if (\substr($url, 0, 6) === '/apps/') {
            // empty string / 'apps' / $app / rest of the route
            list(, , $app, ) = \explode('/', $url, 4);
Severity: Minor
Found in lib/private/Route/Router.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method match has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function match($url) {
        if (\substr($url, 0, 6) === '/apps/') {
            // empty string / 'apps' / $app / rest of the route
            list(, , $app, ) = \explode('/', $url, 4);
Severity: Major
Found in lib/private/Route/Router.php - About 2 hrs to fix

    Function loadRoutes has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

        public function loadRoutes($app = null) {
        if (\is_string($app)) {
            $app = \OC_App::cleanAppId($app);
        }
    Severity: Minor
    Found in lib/private/Route/Router.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method loadRoutes has 55 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function loadRoutes($app = null) {
        if (\is_string($app)) {
            $app = \OC_App::cleanAppId($app);
        }
    Severity: Major
    Found in lib/private/Route/Router.php - About 2 hrs to fix

      File Router.php has 254 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
/**
 * @author Bart Visscher <bartv@thisnet.nl>
 * @author Bernhard Posselt <dev@bernhard-posselt.com>
 * @author Joas Schilling <coding@schilljs.com>
      Severity: Minor
      Found in lib/private/Route/Router.php - About 2 hrs to fix

        Function getRoutingFiles has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getRoutingFiles() {
        if (!isset($this->routingFiles)) {
            $this->routingFiles = [];
            foreach (\OC_App::getEnabledApps() as $app) {
                $appPath = \OC_App::getAppPath($app);
        Severity: Minor
        Found in lib/private/Route/Router.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status