Sign upLogin

owncloud/core

View on GitHub
Star
lib/private/User/User.php

Summary

Maintainability
D
1 day
Test Coverage

File User.php has 373 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * @author Arthur Schiwon <blizzz@arthur-schiwon.de>
 * @author Bart Visscher <bartv@thisnet.nl>
 * @author Björn Schießle <bjoern@schiessle.org>
Severity: Minor
Found in lib/private/User/User.php - About 4 hrs to fix

    User has 32 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class User implements IUser {
    use EventEmitterTrait;

    /** @var Account */
    private $account;
    Severity: Minor
    Found in lib/private/User/User.php - About 4 hrs to fix

      Method delete has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function delete(): bool {
        if ($this->emitter) {
            $this->emitter->emit('\OC\User', 'preDelete', [$this]);
        }
        // get the home now because it won't return it after user deletion
      Severity: Minor
      Found in lib/private/User/User.php - About 1 hr to fix

        Method setPassword has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function setPassword($password, $recoveryPassword = null) {
        if (!$this->allowUserAccountUpdate) {
            throw new NotPermittedActionException("Operation cannot be allowed as other apps are fetching extended attributes of this user.");
        }
        Severity: Minor
        Found in lib/private/User/User.php - About 1 hr to fix

          Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  Account $account,
        AccountMapper $mapper,
        $emitter = null,
        IConfig $config = null,
        $urlGenerator = null,
          Severity: Major
          Found in lib/private/User/User.php - About 1 hr to fix

            Function delete has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                public function delete(): bool {
        if ($this->emitter) {
            $this->emitter->emit('\OC\User', 'preDelete', [$this]);
        }
        // get the home now because it won't return it after user deletion
            Severity: Minor
            Found in lib/private/User/User.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if ($this->userSession instanceof IUserSession) {
            $user = $this->userSession->getUser();
            if (
                ($this->config->getSystemValue('allow_user_to_change_display_name') === false) &&
                (($user !== null) && (!$this->groupManager->isAdmin($user->getUID()))) &&
            Severity: Major
            Found in lib/private/User/User.php and 1 other location - About 1 hr to fix
            lib/private/User/User.php on lines 478..487

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 106.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if ($this->userSession instanceof IUserSession) {
            $user = $this->userSession->getUser();
            if (
                ($this->config->getSystemValue('allow_user_to_change_mail_address') === false) &&
                (($user !== null) && (!$this->groupManager->isAdmin($user->getUID()))) &&
            Severity: Major
            Found in lib/private/User/User.php and 1 other location - About 1 hr to fix
            lib/private/User/User.php on lines 454..463

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 106.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status