Sign upLogin

ozanh/ugo

View on GitHub
Star
optimizer.go

Summary

Maintainability
F
6 days
Test Coverage

Method SimpleOptimizer.optimize has a Cognitive Complexity of 190 (exceeds 20 allowed). Consider refactoring.
Open

func (so *SimpleOptimizer) optimize(node parser.Node) (parser.Expr, bool) {
    if so.trace != nil {
        if node != nil {
            defer untraceoptim(traceoptim(so, fmt.Sprintf("%s (%s)",
                node.String(), reflect.TypeOf(node).Elem().Name())))
Severity: Minor
Found in optimizer.go - About 3 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File optimizer.go has 858 lines of code (exceeds 500 allowed). Consider refactoring.
Wontfix

// Copyright (c) 2020-2023 Ozan Hacıbekiroğlu.
// Use of this source code is governed by a MIT License
// that can be found in the LICENSE file.

package ugo
Severity: Major
Found in optimizer.go - About 1 day to fix

    Method SimpleOptimizer.optimize has 270 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (so *SimpleOptimizer) optimize(node parser.Node) (parser.Expr, bool) {
    if so.trace != nil {
        if node != nil {
            defer untraceoptim(traceoptim(so, fmt.Sprintf("%s (%s)",
                node.String(), reflect.TypeOf(node).Elem().Name())))
    Severity: Major
    Found in optimizer.go - About 1 day to fix

      Method SimpleOptimizer.slowEvalExpr has 87 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (so *SimpleOptimizer) slowEvalExpr(expr parser.Expr) (parser.Expr, bool) {
    st := NewSymbolTable().
        EnableParams(false).
        DisableBuiltin(so.disabledBuiltins...).
        DisableBuiltin(so.scope.shadowedBuiltins()...)
      Severity: Major
      Found in optimizer.go - About 2 hrs to fix

        Method SimpleOptimizer.unaryop has 69 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (so *SimpleOptimizer) unaryop(
    op token.Token,
    expr parser.Expr,
) (parser.Expr, bool) {
        Severity: Minor
        Found in optimizer.go - About 1 hr to fix

          Method SimpleOptimizer.unaryop has 9 return statements (exceeds 4 allowed).
          Open

          func (so *SimpleOptimizer) unaryop(
    op token.Token,
    expr parser.Expr,
) (parser.Expr, bool) {
          Severity: Major
          Found in optimizer.go - About 55 mins to fix

            Method SimpleOptimizer.optimize has 6 return statements (exceeds 4 allowed).
            Open

            func (so *SimpleOptimizer) optimize(node parser.Node) (parser.Expr, bool) {
    if so.trace != nil {
        if node != nil {
            defer untraceoptim(traceoptim(so, fmt.Sprintf("%s (%s)",
                node.String(), reflect.TypeOf(node).Elem().Name())))
            Severity: Major
            Found in optimizer.go - About 40 mins to fix

              Function canOptimizeInsts has 6 return statements (exceeds 4 allowed).
              Open

              func canOptimizeInsts(constants []Object, insts []byte) bool {
    if len(insts) == 0 {
        return false
    }
              Severity: Major
              Found in optimizer.go - About 40 mins to fix

                Method SimpleOptimizer.binaryop has 5 return statements (exceeds 4 allowed).
                Open

                func (so *SimpleOptimizer) binaryop(
    op token.Token,
    left, right parser.Expr,
) (parser.Expr, bool) {
                Severity: Major
                Found in optimizer.go - About 35 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      case *parser.UintLit:
        switch op {
        case token.Not:
            v := expr.Value == 0
            return &parser.BoolLit{
                  Severity: Major
                  Found in optimizer.go and 1 other location - About 2 hrs to fix
                  optimizer.go on lines 497..522

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 207.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      case *parser.IntLit:
        switch op {
        case token.Not:
            v := expr.Value == 0
            return &parser.BoolLit{
                  Severity: Major
                  Found in optimizer.go and 1 other location - About 2 hrs to fix
                  optimizer.go on lines 523..548

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 207.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status