Sign upLogin

ozanh/ugo

View on GitHub
Star

Showing 324 of 517 total issues

Method SimpleOptimizer.optimize has a Cognitive Complexity of 190 (exceeds 20 allowed). Consider refactoring.
Open

func (so *SimpleOptimizer) optimize(node parser.Node) (parser.Expr, bool) {
    if so.trace != nil {
        if node != nil {
            defer untraceoptim(traceoptim(so, fmt.Sprintf("%s (%s)",
                node.String(), reflect.TypeOf(node).Elem().Name())))
Severity: Minor
Found in optimizer.go - About 3 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method VM.loop has a Cognitive Complexity of 163 (exceeds 20 allowed). Consider refactoring.
Confirmed

func (vm *VM) loop() {
VMLoop:
    for atomic.LoadInt64(&vm.abort) == 0 {
        vm.ip++
        switch vm.curInsts[vm.ip] {
Severity: Minor
Found in vm.go - About 3 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File compiler_nodes.go has 955 lines of code (exceeds 500 allowed). Consider refactoring.
Open

// Copyright (c) 2020-2023 Ozan Hacıbekiroğlu.
// Use of this source code is governed by a MIT License
// that can be found in the LICENSE file.

package ugo
Severity: Major
Found in compiler_nodes.go - About 1 day to fix

    Method SimpleOptimizer.optimize has 270 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (so *SimpleOptimizer) optimize(node parser.Node) (parser.Expr, bool) {
    if so.trace != nil {
        if node != nil {
            defer untraceoptim(traceoptim(so, fmt.Sprintf("%s (%s)",
                node.String(), reflect.TypeOf(node).Elem().Name())))
    Severity: Major
    Found in optimizer.go - About 1 day to fix

      Parser has 51 methods (exceeds 20 allowed). Consider refactoring.
      Open

      type Parser struct {
    file      *SourceFile
    errors    ErrorList
    scanner   *Scanner
    pos       Pos
      Severity: Major
      Found in parser/parser.go - About 7 hrs to fix

        Method Scanner.Scan has a Cognitive Complexity of 47 (exceeds 20 allowed). Consider refactoring.
        Open

        func (s *Scanner) Scan() (
    tok token.Token,
    literal string,
    pos Pos,
) {
        Severity: Minor
        Found in parser/scanner.go - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method Scanner.Scan has 143 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (s *Scanner) Scan() (
    tok token.Token,
    literal string,
    pos Pos,
) {
        Severity: Major
        Found in parser/scanner.go - About 4 hrs to fix

          VM has 36 methods (exceeds 20 allowed). Consider refactoring.
          Open

          type VM struct {
    abort        int64
    sp           int
    ip           int
    curInsts     []byte
          Severity: Minor
          Found in vm.go - About 4 hrs to fix

            Compiler has 34 methods (exceeds 20 allowed). Consider refactoring.
            Open

            func (c *Compiler) compileIfStmt(node *parser.IfStmt) error {
    // open new symbol table for the statement
    c.symbolTable = c.symbolTable.Fork(true)
    defer func() {
        c.symbolTable = c.symbolTable.Parent(false)
            Severity: Minor
            Found in compiler_nodes.go - About 4 hrs to fix

              File scanner.go has 590 lines of code (exceeds 500 allowed). Consider refactoring.
              Open

              // A modified version Go and Tengo parsers.

// Copyright (c) 2020-2023 Ozan Hacıbekiroğlu.
// Use of this source code is governed by a MIT License
// that can be found in the LICENSE file.
              Severity: Minor
              Found in parser/scanner.go - About 4 hrs to fix

                Method VM.xOpCallCompiled has a Cognitive Complexity of 42 (exceeds 20 allowed). Consider refactoring.
                Confirmed

                func (vm *VM) xOpCallCompiled(cfunc *CompiledFunction, numArgs, flags int) error {
    basePointer := vm.sp - numArgs
    numLocals := cfunc.NumLocals
    numParams := cfunc.NumParams
                Severity: Minor
                Found in vm.go - About 3 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                    case Int:
        switch tok {
        case token.Add:
            return bval + v, nil
        case token.Sub:
                Severity: Major
                Found in objects.go and 3 other locations - About 3 hrs to fix
                numeric.go on lines 79..114
                numeric.go on lines 225..260
                numeric.go on lines 491..526

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 280.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                    case Int:
        switch tok {
        case token.Add:
            return o + v, nil
        case token.Sub:
                Severity: Major
                Found in numeric.go and 3 other locations - About 3 hrs to fix
                numeric.go on lines 225..260
                numeric.go on lines 491..526
                objects.go on lines 380..415

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 280.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                    case Uint:
        switch tok {
        case token.Add:
            return o + v, nil
        case token.Sub:
                Severity: Major
                Found in numeric.go and 3 other locations - About 3 hrs to fix
                numeric.go on lines 79..114
                numeric.go on lines 491..526
                objects.go on lines 380..415

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 280.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                    case Char:
        switch tok {
        case token.Add:
            return o + v, nil
        case token.Sub:
                Severity: Major
                Found in numeric.go and 3 other locations - About 3 hrs to fix
                numeric.go on lines 79..114
                numeric.go on lines 225..260
                objects.go on lines 380..415

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 280.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Method Scanner.scanNumber has a Cognitive Complexity of 39 (exceeds 20 allowed). Consider refactoring.
                Open

                func (s *Scanner) scanNumber(seenDecimalPoint bool) (tok token.Token, lit string) {
    // digitVal(s.ch) < 10
    offs := s.offset
    tok = token.Int
                Severity: Minor
                Found in parser/scanner.go - About 3 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method Bool.BinaryOp has 98 lines of code (exceeds 50 allowed). Consider refactoring.
                Open

                func (o Bool) BinaryOp(tok token.Token, right Object) (Object, error) {
    bval := Int(0)
    if o {
        bval = Int(1)
    }
                Severity: Major
                Found in objects.go - About 2 hrs to fix

                  Method VM.xOpCallCompiled has 96 lines of code (exceeds 50 allowed). Consider refactoring.
                  Confirmed

                  func (vm *VM) xOpCallCompiled(cfunc *CompiledFunction, numArgs, flags int) error {
    basePointer := vm.sp - numArgs
    numLocals := cfunc.NumLocals
    numParams := cfunc.NumParams
                  Severity: Major
                  Found in vm.go - About 2 hrs to fix

                    Method Char.BinaryOp has 95 lines of code (exceeds 50 allowed). Consider refactoring.
                    Open

                    func (o Char) BinaryOp(tok token.Token, right Object) (Object, error) {
    switch v := right.(type) {
    case Char:
        switch tok {
        case token.Add:
                    Severity: Major
                    Found in numeric.go - About 2 hrs to fix

                      Method Parser.parseOperand has 89 lines of code (exceeds 50 allowed). Consider refactoring.
                      Open

                      func (p *Parser) parseOperand() Expr {
    if p.trace {
        defer untracep(tracep(p, "Operand"))
    }
                      Severity: Major
                      Found in parser/parser.go - About 2 hrs to fix
                        Severity
                        Category
                        Status
                        Source
                        Language