Sign upLogin

ozanh/ugo

View on GitHub
Star
parser/parser.go

Summary

Maintainability
D
1 day
Test Coverage

File parser.go has 1250 lines of code (exceeds 500 allowed). Consider refactoring.
Wontfix

// A modified version Go and Tengo parsers.

// Copyright (c) 2020-2023 Ozan Hacıbekiroğlu.
// Use of this source code is governed by a MIT License
// that can be found in the LICENSE file.
Severity: Major
Found in parser/parser.go - About 2 days to fix

    Parser has 51 methods (exceeds 20 allowed). Consider refactoring.
    Open

    type Parser struct {
    file      *SourceFile
    errors    ErrorList
    scanner   *Scanner
    pos       Pos
    Severity: Major
    Found in parser/parser.go - About 7 hrs to fix

      Method Parser.parseOperand has 89 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (p *Parser) parseOperand() Expr {
    if p.trace {
        defer untracep(tracep(p, "Operand"))
    }
      Severity: Major
      Found in parser/parser.go - About 2 hrs to fix

        Method Parser.parseSimpleStmt has 71 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (p *Parser) parseSimpleStmt(forIn bool) Stmt {
    if p.trace {
        defer untracep(tracep(p, "SimpleStmt"))
    }
        Severity: Minor
        Found in parser/parser.go - About 1 hr to fix

          Method Parser.parseOperand has 9 return statements (exceeds 4 allowed).
          Open

          func (p *Parser) parseOperand() Expr {
    if p.trace {
        defer untracep(tracep(p, "Operand"))
    }
          Severity: Major
          Found in parser/parser.go - About 55 mins to fix

            Method Parser.parseSimpleStmt has 5 return statements (exceeds 4 allowed).
            Open

            func (p *Parser) parseSimpleStmt(forIn bool) Stmt {
    if p.trace {
        defer untracep(tracep(p, "SimpleStmt"))
    }
            Severity: Major
            Found in parser/parser.go - About 35 mins to fix

              Method Parser.parseSimpleStmt has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
              Open

              func (p *Parser) parseSimpleStmt(forIn bool) Stmt {
    if p.trace {
        defer untracep(tracep(p, "SimpleStmt"))
    }
              Severity: Minor
              Found in parser/parser.go - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              TODO found
              Open

                              //TODO: no more than 2 idents
              Severity: Minor
              Found in parser/parser.go by fixme

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              func (p *Parser) parseBody() *BlockStmt {
    if p.trace {
        defer untracep(tracep(p, "Body"))
    }
              Severity: Minor
              Found in parser/parser.go and 1 other location - About 50 mins to fix
              parser/parser.go on lines 1032..1045

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 118.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              func (p *Parser) parseBlockStmt() *BlockStmt {
    if p.trace {
        defer untracep(tracep(p, "BlockStmt"))
    }
              Severity: Minor
              Found in parser/parser.go and 1 other location - About 50 mins to fix
              parser/parser.go on lines 615..628

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 118.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status