Sign upLogin

ozanh/ugo

View on GitHub
Star
stdlib/json/encode.go

Summary

Maintainability
A
0 mins
Test Coverage

Method encodeState.string has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
Wontfix

func (e *encodeState) string(s string, escapeHTML bool) {
    e.WriteByte('"')
    start := 0
    for i := 0; i < len(s); {
        if b := s[i]; b < utf8.RuneSelf {
Severity: Minor
Found in stdlib/json/encode.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method encodeState.stringBytes has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
Wontfix

func (e *encodeState) stringBytes(s []byte, escapeHTML bool) {
    e.WriteByte('"')
    start := 0
    for i := 0; i < len(s); {
        if b := s[i]; b < utf8.RuneSelf {
Severity: Minor
Found in stdlib/json/encode.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method encodeState.stringBytes has 56 lines of code (exceeds 50 allowed). Consider refactoring.
Wontfix

func (e *encodeState) stringBytes(s []byte, escapeHTML bool) {
    e.WriteByte('"')
    start := 0
    for i := 0; i < len(s); {
        if b := s[i]; b < utf8.RuneSelf {
Severity: Minor
Found in stdlib/json/encode.go - About 1 hr to fix

    Method encodeState.string has 56 lines of code (exceeds 50 allowed). Consider refactoring.
    Wontfix

    func (e *encodeState) string(s string, escapeHTML bool) {
    e.WriteByte('"')
    start := 0
    for i := 0; i < len(s); {
        if b := s[i]; b < utf8.RuneSelf {
    Severity: Minor
    Found in stdlib/json/encode.go - About 1 hr to fix

      Function mapEncoder has 51 lines of code (exceeds 50 allowed). Consider refactoring.
      Wontfix

      func mapEncoder(e *encodeState, v ugo.Object, opts encOpts) {
    if v == nil {
        e.WriteString("null")
        return
    }
      Severity: Minor
      Found in stdlib/json/encode.go - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Wontfix

        func (e *encodeState) stringBytes(s []byte, escapeHTML bool) {
    e.WriteByte('"')
    start := 0
    for i := 0; i < len(s); {
        if b := s[i]; b < utf8.RuneSelf {
        Severity: Major
        Found in stdlib/json/encode.go and 1 other location - About 6 hrs to fix
        stdlib/json/encode.go on lines 483..552

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 478.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Wontfix

        func (e *encodeState) string(s string, escapeHTML bool) {
    e.WriteByte('"')
    start := 0
    for i := 0; i < len(s); {
        if b := s[i]; b < utf8.RuneSelf {
        Severity: Major
        Found in stdlib/json/encode.go and 1 other location - About 6 hrs to fix
        stdlib/json/encode.go on lines 555..624

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 478.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Wontfix

        func intEncoder(e *encodeState, v ugo.Object, opts encOpts) {
    b := strconv.AppendInt(e.scratch[:0], int64(v.(ugo.Int)), 10)
    if opts.quoted {
        e.WriteByte('"')
    }
        Severity: Major
        Found in stdlib/json/encode.go and 2 other locations - About 50 mins to fix
        stdlib/json/encode.go on lines 224..233
        stdlib/json/encode.go on lines 274..283

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 120.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Wontfix

        func charEncoder(e *encodeState, v ugo.Object, opts encOpts) {
    b := strconv.AppendInt(e.scratch[:0], int64(v.(ugo.Char)), 10)
    if opts.quoted {
        e.WriteByte('"')
    }
        Severity: Major
        Found in stdlib/json/encode.go and 2 other locations - About 50 mins to fix
        stdlib/json/encode.go on lines 213..222
        stdlib/json/encode.go on lines 224..233

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 120.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Wontfix

        func uintEncoder(e *encodeState, v ugo.Object, opts encOpts) {
    b := strconv.AppendUint(e.scratch[:0], uint64(v.(ugo.Uint)), 10)
    if opts.quoted {
        e.WriteByte('"')
    }
        Severity: Major
        Found in stdlib/json/encode.go and 2 other locations - About 50 mins to fix
        stdlib/json/encode.go on lines 213..222
        stdlib/json/encode.go on lines 274..283

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 120.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status