Sign upLogin

ozanh/ugo

View on GitHub
Star
stdlib/strings/module.go

Summary

Maintainability
A
40 mins
Test Coverage

File module.go has 545 lines of code (exceeds 500 allowed). Consider refactoring.
Invalid

// Copyright (c) 2020-2023 Ozan Hacıbekiroğlu.
// Use of this source code is governed by a MIT License
// that can be found in the LICENSE file.

// Package strings provides strings module implementing simple functions to
Severity: Minor
Found in stdlib/strings/module.go - About 3 hrs to fix

    Function pad has 6 return statements (exceeds 4 allowed).
    Confirmed

    func pad(c ugo.Call, left bool) (ugo.Object, error) {
    size := c.Len()
    if size != 2 && size != 3 {
        return ugo.Undefined,
            ugo.ErrWrongNumArguments.NewError("want=2..3 got=" + strconv.Itoa(size))
    Severity: Major
    Found in stdlib/strings/module.go - About 40 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Invalid

      func newTrimFuncInv(fn func(string, func(rune) bool) string) ugo.CallableExFunc {
    return func(c ugo.Call) (ugo.Object, error) {
        return stringInvoke(c, 0, 1,
            func(s string, inv *ugo.Invoker) (ugo.Object, error) {
                var err error
      Severity: Major
      Found in stdlib/strings/module.go and 1 other location - About 3 hrs to fix
      stdlib/strings/module.go on lines 703..723

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 255.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Invalid

      func newIndexFuncInv(fn func(string, func(rune) bool) int) ugo.CallableExFunc {
    return func(c ugo.Call) (ugo.Object, error) {
        return stringInvoke(c, 0, 1,
            func(s string, inv *ugo.Invoker) (ugo.Object, error) {
                var err error
      Severity: Major
      Found in stdlib/strings/module.go and 1 other location - About 3 hrs to fix
      stdlib/strings/module.go on lines 725..745

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 255.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Invalid

          "PadLeft": &ugo.Function{
        Name: "PadLeft",
        Value: func(args ...ugo.Object) (ugo.Object, error) {
            return pad(ugo.NewCall(nil, args), true)
        },
      Severity: Minor
      Found in stdlib/strings/module.go and 1 other location - About 45 mins to fix
      stdlib/strings/module.go on lines 230..238

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 116.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Invalid

          "PadRight": &ugo.Function{
        Name: "PadRight",
        Value: func(args ...ugo.Object) (ugo.Object, error) {
            return pad(ugo.NewCall(nil, args), false)
        },
      Severity: Minor
      Found in stdlib/strings/module.go and 1 other location - About 45 mins to fix
      stdlib/strings/module.go on lines 216..224

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 116.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status