Sign upLogin

pac4j/pac4j

View on GitHub
Star
pac4j-config/src/main/java/org/pac4j/config/client/PropertiesConfigFactory.java

Summary

Maintainability
D
1 day
Test Coverage

Method hasOAuthClients has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    protected boolean hasOAuthClients() {
        if (isNotBlank(getProperty(LINKEDIN_ID)) && isNotBlank(getProperty(LINKEDIN_SECRET))) {
            return true;
        }
        if (isNotBlank(getProperty(FACEBOOK_ID)) && isNotBlank(getProperty(FACEBOOK_SECRET))) {
Severity: Minor
Found in pac4j-config/src/main/java/org/pac4j/config/client/PropertiesConfigFactory.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method build has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Override
    public Config build(final Object... parameters) {

        final List<Client> clients = new ArrayList<>();
        final Map<String, Authenticator> authenticators = new HashMap<>();
Severity: Major
Found in pac4j-config/src/main/java/org/pac4j/config/client/PropertiesConfigFactory.java - About 2 hrs to fix

    Method hasHttpAuthenticatorsOrClients has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        protected boolean hasHttpAuthenticatorsOrClients() {
        if (isNotBlank(getProperty(ANONYMOUS))) {
            return true;
        }
        for (var i = 0; i <= MAX_NUM_AUTHENTICATORS; i++) {
    Severity: Minor
    Found in pac4j-config/src/main/java/org/pac4j/config/client/PropertiesConfigFactory.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method hasOAuthClients has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected boolean hasOAuthClients() {
        if (isNotBlank(getProperty(LINKEDIN_ID)) && isNotBlank(getProperty(LINKEDIN_SECRET))) {
            return true;
        }
        if (isNotBlank(getProperty(FACEBOOK_ID)) && isNotBlank(getProperty(FACEBOOK_SECRET))) {
    Severity: Minor
    Found in pac4j-config/src/main/java/org/pac4j/config/client/PropertiesConfigFactory.java - About 1 hr to fix

      Method build has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          @Override
    public Config build(final Object... parameters) {

        final List<Client> clients = new ArrayList<>();
        final Map<String, Authenticator> authenticators = new HashMap<>();
      Severity: Minor
      Found in pac4j-config/src/main/java/org/pac4j/config/client/PropertiesConfigFactory.java - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                  return true;
      Severity: Major
      Found in pac4j-config/src/main/java/org/pac4j/config/client/PropertiesConfigFactory.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return true;
        Severity: Major
        Found in pac4j-config/src/main/java/org/pac4j/config/client/PropertiesConfigFactory.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return true;
          Severity: Major
          Found in pac4j-config/src/main/java/org/pac4j/config/client/PropertiesConfigFactory.java - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return true;
            Severity: Major
            Found in pac4j-config/src/main/java/org/pac4j/config/client/PropertiesConfigFactory.java - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return false;
              Severity: Major
              Found in pac4j-config/src/main/java/org/pac4j/config/client/PropertiesConfigFactory.java - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return true;
                Severity: Major
                Found in pac4j-config/src/main/java/org/pac4j/config/client/PropertiesConfigFactory.java - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                          return false;
                  Severity: Major
                  Found in pac4j-config/src/main/java/org/pac4j/config/client/PropertiesConfigFactory.java - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                return true;
                    Severity: Major
                    Found in pac4j-config/src/main/java/org/pac4j/config/client/PropertiesConfigFactory.java - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                  return true;
                      Severity: Major
                      Found in pac4j-config/src/main/java/org/pac4j/config/client/PropertiesConfigFactory.java - About 30 mins to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            protected boolean hasSpringEncoder() {
        for (var i = 0; i <= MAX_NUM_ENCODERS; i++) {
            val type = getProperty(SPRING_ENCODER_TYPE, i);
            if (isNotBlank(type)) {
                return true;
                        Severity: Minor
                        Found in pac4j-config/src/main/java/org/pac4j/config/client/PropertiesConfigFactory.java and 1 other location - About 40 mins to fix
                        pac4j-config/src/main/java/org/pac4j/config/client/PropertiesConfigFactory.java on lines 156..164

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 51.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            protected boolean hasLdapAuthenticator() {
        for (var i = 0; i <= MAX_NUM_AUTHENTICATORS; i++) {
            val type = getProperty(LDAP_TYPE, i);
            if (isNotBlank(type)) {
                return true;
                        Severity: Minor
                        Found in pac4j-config/src/main/java/org/pac4j/config/client/PropertiesConfigFactory.java and 1 other location - About 40 mins to fix
                        pac4j-config/src/main/java/org/pac4j/config/client/PropertiesConfigFactory.java on lines 141..149

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 51.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status