Sign upLogin

pac4j/pac4j

View on GitHub
Star
pac4j-core/src/main/java/org/pac4j/core/authorization/checker/DefaultAuthorizationChecker.java

Summary

Maintainability
B
4 hrs
Test Coverage

Method retrieveAuthorizer has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    protected Authorizer retrieveAuthorizer(final String authorizerName, final Map<String, Authorizer> authorizersMap) {
        Authorizer authorizer = null;
        for (val entry : authorizersMap.entrySet()) {
            if (areEqualsIgnoreCaseAndTrim(entry.getKey(), authorizerName)) {
                authorizer = entry.getValue();
Severity: Minor
Found in pac4j-core/src/main/java/org/pac4j/core/authorization/checker/DefaultAuthorizationChecker.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method isAuthorized has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public boolean isAuthorized(final WebContext context, final SessionStore sessionStore, final List<UserProfile> profiles,
                                final String authorizersValue, final Map<String, Authorizer> authorizersMap, final List<Client> clients) {
Severity: Minor
Found in pac4j-core/src/main/java/org/pac4j/core/authorization/checker/DefaultAuthorizationChecker.java - About 45 mins to fix

    Method computeAuthorizers has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        protected List<Authorizer> computeAuthorizers(final WebContext context, final List<UserProfile> profiles, final String authorizersValue,
                                                  final Map<String, Authorizer> authorizersMap, final List<Client> clients) {
    Severity: Minor
    Found in pac4j-core/src/main/java/org/pac4j/core/authorization/checker/DefaultAuthorizationChecker.java - About 35 mins to fix

      Method isAuthorized has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          protected boolean isAuthorized(final WebContext context, final SessionStore sessionStore,
                                   final List<UserProfile> profiles, final Collection<Authorizer> authorizers) {
        // authorizations check comes after authentication and profile must not be null nor empty
        assertTrue(isNotEmpty(profiles), "profiles must not be null or empty");
        if (isNotEmpty(authorizers)) {
      Severity: Minor
      Found in pac4j-core/src/main/java/org/pac4j/core/authorization/checker/DefaultAuthorizationChecker.java - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                      return CSRF_AUTHORIZER;
      Severity: Major
      Found in pac4j-core/src/main/java/org/pac4j/core/authorization/checker/DefaultAuthorizationChecker.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return authorizer;
        Severity: Major
        Found in pac4j-core/src/main/java/org/pac4j/core/authorization/checker/DefaultAuthorizationChecker.java - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status