Sign upLogin

pac4j/pac4j

View on GitHub
Star
pac4j-core/src/main/java/org/pac4j/core/profile/service/AbstractProfileService.java

Summary

Maintainability
C
7 hrs
Test Coverage

Method convertAttributesToProfile has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    protected U convertAttributesToProfile(final List<Map<String, Object>> listStorageAttributes, final String username) {
        if (listStorageAttributes == null || listStorageAttributes.size() == 0) {
            return null;
        }
        val storageAttributes = listStorageAttributes.get(0);
Severity: Minor
Found in pac4j-core/src/main/java/org/pac4j/core/profile/service/AbstractProfileService.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method convertAttributesToProfile has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected U convertAttributesToProfile(final List<Map<String, Object>> listStorageAttributes, final String username) {
        if (listStorageAttributes == null || listStorageAttributes.size() == 0) {
            return null;
        }
        val storageAttributes = listStorageAttributes.get(0);
Severity: Minor
Found in pac4j-core/src/main/java/org/pac4j/core/profile/service/AbstractProfileService.java - About 1 hr to fix

    Method validate has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        @Override
    public Optional<Credentials> validate(final CallContext ctx, Credentials cred) {
        init();

        assertNotNull("credentials", cred);
    Severity: Minor
    Found in pac4j-core/src/main/java/org/pac4j/core/profile/service/AbstractProfileService.java - About 1 hr to fix

      Method internalInit has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          @Override
    protected void internalInit(final boolean forceReinit) {
        assertNotNull("profileDefinition", getProfileDefinition());
        assertNotBlank("usernameAttribute", this.usernameAttribute);
        assertNotBlank("passwordAttribute", this.passwordAttribute);
      Severity: Minor
      Found in pac4j-core/src/main/java/org/pac4j/core/profile/service/AbstractProfileService.java - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method validate has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          @Override
    public Optional<Credentials> validate(final CallContext ctx, Credentials cred) {
        init();

        assertNotNull("credentials", cred);
      Severity: Minor
      Found in pac4j-core/src/main/java/org/pac4j/core/profile/service/AbstractProfileService.java - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method convertProfileAndPasswordToAttributes has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          protected Map<String, Object> convertProfileAndPasswordToAttributes(final U profile, final String password) {
        Map<String, Object> storageAttributes = new HashMap<>();
        storageAttributes.put(getIdAttribute(), profile.getId());
        storageAttributes.put(LINKEDID, profile.getLinkedId());
        storageAttributes.put(getUsernameAttribute(), profile.getUsername());
      Severity: Minor
      Found in pac4j-core/src/main/java/org/pac4j/core/profile/service/AbstractProfileService.java - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status