Sign upLogin

pac4j/pac4j

View on GitHub
Star
pac4j-oauth/src/main/java/org/pac4j/oauth/profile/JsonHelper.java

Summary

Maintainability
B
4 hrs
Test Coverage

Method getElement has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    public static Object getElement(final JsonNode json, final String name) {
        if (json != null && name != null) {
            var node = json;
            for (var nodeName : name.split("\\.")) {
                if (node != null) {
Severity: Minor
Found in pac4j-oauth/src/main/java/org/pac4j/oauth/profile/JsonHelper.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getElement has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static Object getElement(final JsonNode json, final String name) {
        if (json != null && name != null) {
            var node = json;
            for (var nodeName : name.split("\\.")) {
                if (node != null) {
Severity: Minor
Found in pac4j-oauth/src/main/java/org/pac4j/oauth/profile/JsonHelper.java - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

                        return node.numberValue();
    Severity: Major
    Found in pac4j-oauth/src/main/java/org/pac4j/oauth/profile/JsonHelper.java - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return null;
      Severity: Major
      Found in pac4j-oauth/src/main/java/org/pac4j/oauth/profile/JsonHelper.java - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status