Sign upLogin

pac4j/pac4j

View on GitHub
Star
pac4j-saml/src/main/java/org/pac4j/saml/sso/impl/SAML2AuthnRequestBuilder.java

Summary

Maintainability
B
6 hrs
Test Coverage

Method buildAuthnRequest has 83 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @SuppressWarnings("unchecked")
    protected final AuthnRequest buildAuthnRequest(final SAML2MessageContext context,
                                                   final Endpoint assertionConsumerService,
                                                   final Endpoint ssoService) {
        val configContext = context.getConfigurationContext();
Severity: Major
Found in pac4j-saml/src/main/java/org/pac4j/saml/sso/impl/SAML2AuthnRequestBuilder.java - About 3 hrs to fix

    Method buildAuthnRequest has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        @SuppressWarnings("unchecked")
    protected final AuthnRequest buildAuthnRequest(final SAML2MessageContext context,
                                                   final Endpoint assertionConsumerService,
                                                   final Endpoint ssoService) {
        val configContext = context.getConfigurationContext();
    Severity: Minor
    Found in pac4j-saml/src/main/java/org/pac4j/saml/sso/impl/SAML2AuthnRequestBuilder.java - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return null;
    Severity: Major
    Found in pac4j-saml/src/main/java/org/pac4j/saml/sso/impl/SAML2AuthnRequestBuilder.java - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status