Sign upLogin

pac4j/pac4j

View on GitHub
Star
pac4j-saml/src/main/java/org/pac4j/saml/transport/Pac4jHTTPPostEncoder.java

Summary

Maintainability
A
2 hrs
Test Coverage

Method populateVelocityContext has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected void populateVelocityContext(final Context velocityContext, final MessageContext messageContext,
                                           final String endpointURL) throws MessageEncodingException {

        val encodedEndpointURL = HTMLEncoder.encodeForHTMLAttribute(endpointURL);
        LOGGER.debug("Encoding action url of '{}' with encoded value '{}'", endpointURL, encodedEndpointURL);
Severity: Minor
Found in pac4j-saml/src/main/java/org/pac4j/saml/transport/Pac4jHTTPPostEncoder.java - About 1 hr to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        protected void postEncode(final MessageContext messageContext, final String endpointURL) throws MessageEncodingException {
        LOGGER.debug("Invoking Velocity template to create POST body");

        try {
            val velocityContext = new VelocityContext();
    Severity: Major
    Found in pac4j-saml/src/main/java/org/pac4j/saml/transport/Pac4jHTTPPostEncoder.java and 1 other location - About 1 hr to fix
    pac4j-saml/src/main/java/org/pac4j/saml/transport/Pac4jHTTPPostSimpleSignEncoder.java on lines 52..69

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 97.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status